[ 
http://issues.apache.org/jira/browse/DERBY-924?page=comments#action_12374100 ] 

Knut Anders Hatlen commented on DERBY-924:
------------------------------------------

Committed revision 393304.

I made some small changes to the patch before committing it:

   - two of the jdk16 canons touched by the patch were removed by the
     DERBY-1178 fix
   - updated jdk13 canon for metadata.java on DerbyNetClient

I still have one minor question about the patch. getFunctionsX() ends
with these two lines:

        lastGetProceduresResultSet_ = executeCatalogQuery(cs);
        return lastGetProceduresResultSet_;

Should this have been lastGetFunctionsResultSet_ instead? Not that it
matters, since none of the lastGetXXXResultSet_ variables seem to have
any other purpose than ensuring that a lot of garbage is kept on the
heap.

> new JDBC4 metadata API getFunctions() needs to be implemented
> -------------------------------------------------------------
>
>          Key: DERBY-924
>          URL: http://issues.apache.org/jira/browse/DERBY-924
>      Project: Derby
>         Type: New Feature

>   Components: JDBC
>     Versions: 10.2.0.0
>  Environment: JDK 1.6
>     Reporter: David Van Couvering
>     Assignee: Dyre Tjeldvoll
>      Fix For: 10.2.0.0
>  Attachments: derby-924.v1.diff, derby-924.v1.stat, derby-924.v2.diff, 
> derby-924.v2.stat, derby-924.v3.diff, derby-924.v3.report.txt, 
> derby-924.v3.stat, derbyall_report.txt, derbyall_report.v1.txt
>
> For now I am implementing this to return empty result set so at least we're 
> compliant, but we should be able to implement this one

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

Reply via email to