[ http://issues.apache.org/jira/browse/DERBY-1965?page=comments#action_12442990 ] Mamta A. Satoor commented on DERBY-1965: ----------------------------------------
Dan, I looked through the patch and wondered why do you do closeSocket(); in the finally block for methods sysinfo() and runtimeInfo() whereas in all the other places, closeSocket(); is not inside the finally block? Also, you probably didn't have any comments for the new method closeSocket() because it is self explanatory but I wonder if we should put something for this method since there is comment for the existing method setUpSocket(). Other than this, the patch looks good to me. > NetworkServerControlImpl never closes the socket or streams it opens in > setUpSocket. > ------------------------------------------------------------------------------------ > > Key: DERBY-1965 > URL: http://issues.apache.org/jira/browse/DERBY-1965 > Project: Derby > Issue Type: Improvement > Components: Network Server > Reporter: Daniel John Debrunner > Assigned To: Daniel John Debrunner > Priority: Minor > Attachments: derby1965_diff.txt > > > Every method that calls setUpSocket should have a call to a new > closeSocket() method. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
