[
https://issues.apache.org/jira/browse/DERBY-2257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12474655
]
V.Narayanan commented on DERBY-2257:
------------------------------------
Thank you for taking a look at the patch. Pls find a couple of answers inline.
The rest of the comments you have placed are very valid and I have no argument
to offer to them except that I will do the same and post it in my next patch.
Thank you for the review.
- Does EmbedConnection.lobHashTable need to be a Hashtable, or could it be an
unsynchronized HashMap. The comments say that it is a HashMap, and I think all
uses of it will already be synchronized on the connection object.
Ans: If you notice the doc I had written along with the patch i had requested
for advice regarding this issue because I wasn't sure about the synchronization
issue. I can change this to a HashMap in my next patch.
- Perhaps the suite() method could mention why the tests only run in embedded
mode?
I will make this to run in the client mode in my next patch. Making them run in
the embedded mode alone is a mistake which I had failed to catch while
submitting the patch. I noticed it today morning and would've placed a comment
to the same effect.
> Implementing the stored procedures called by the LOB related JDBC methods
> -------------------------------------------------------------------------
>
> Key: DERBY-2257
> URL: https://issues.apache.org/jira/browse/DERBY-2257
> Project: Derby
> Issue Type: Sub-task
> Components: JDBC
> Environment: All environments
> Reporter: V.Narayanan
> Assigned To: V.Narayanan
> Attachments: Expln_StoredProc_LOB.txt, Expln_StoredProc_LOB_v2.txt,
> StoredProcedures_v1.diff, StoredProcedures_v1.stat, StoredProcedures_v2.diff,
> StoredProcedures_v2.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
