[ 
https://issues.apache.org/jira/browse/DERBY-2336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mike Matrigali updated DERBY-2336:
----------------------------------


This patch seems a reasonable approach to make sure the information is 
available at the lowest level of the system and in an efficient manner.  The 
collation info is definitely needed during restart recovery as logical undo of 
btree transactions may require traversing the tree and thus will need to make 
sure comparisons are done with the same collation as they were
created.  Recovery runs with only the raw store context on the stack so the 
info needs to be available there.

Later when you get colllations actually working you should add a recovery 
scenario to make sure this gets tested.  I'll think a little more about what 
should happen, but at least you should have an outstand transaction with 
insert/delete/updates that affect one or more character indexes (all with a 
collation setting in the db that is different from default one today).  Make 
sure those log records get to the log (easiest is to either write a LOT of them 
or to have another xact commit), and then crash the server.  Restart  the 
server will then run through the code.  The following are examples of using 
.sql tests to force restart
recover in old test harness - simply exits after doing work and then restarts 
on same db:
store/oc_rec1.java
store/oc_rec2.java
store/oc_rec3.java
store/oc_rec4.java

I am not sure how to handle this in junit tests, we have counted on crashing 
jvm providing the testing scenario we need.

Looks good as first step checkin, assuming tests pass I say you should go ahead 
and check in.

> Enable collation based ordering for CHAR data type.
> ---------------------------------------------------
>
>                 Key: DERBY-2336
>                 URL: https://issues.apache.org/jira/browse/DERBY-2336
>             Project: Derby
>          Issue Type: Sub-task
>          Components: SQL
>    Affects Versions: 10.3.0.0
>            Reporter: Mamta A. Satoor
>         Attachments: DERBY_LocalFinder_CodeCleanup_diff_V01.txt, 
> DERBY_LocalFinder_CodeCleanup_stat_V01.txt
>
>
> I am breaking down the Parent task DERBY-1478 (Add built in language based 
> ordering and like processing to Derby) into multiple sub tasks. One of them 
> is to concentrate on enabling the collation based ordering on (hopefully the 
> simplest of all the character data types) CHAR data type. This task in itself 
> might need subtasks if it is later found that it can be subdivided into 
> multiple smaller steps.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to