[
https://issues.apache.org/jira/browse/DERBY-2443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12483917
]
Knut Anders Hatlen commented on DERBY-2443:
-------------------------------------------
The patch looks good to me. A couple of small comments:
I get these warnings when generating javadoc:
client/am/ResultSet.java:6100: warning - @param argument "columnLabel" is not a
parameter name.
client/am/ResultSet.java:6125: warning - @param argument "columnLabel" is not a
parameter name.
The tests have much code similar to this:
+ Reader r1 = new java.io.StringReader(new String(BYTES1));
I'm not sure how safe it is to use the String(byte[]) constructor without
specifying the encoding. Perhaps it would be better to use a hard-coded string?
I assume the changes to index.html were not supposed to be part of the patch?
> Implement ResultSet updateClob/updateBlob methods on the NetworkClient
> -----------------------------------------------------------------------
>
> Key: DERBY-2443
> URL: https://issues.apache.org/jira/browse/DERBY-2443
> Project: Derby
> Issue Type: Improvement
> Components: Network Client
> Environment: All
> Reporter: V.Narayanan
> Assigned To: V.Narayanan
> Attachments: ResultSetNotImplMethods_v1.diff,
> ResultSetNotImplMethods_v1.stat, ResultSetNotImplMethods_v2.diff,
> ResultSetNotImplMethods_v2.stat
>
>
> Implement the following ResultSet methods on the Network Client
> updateBlob(int columnIndex, Blob x)
> updateBlob(String columnName, Blob x)
> updateClob(int columnIndex, Clob x)
> updateClob(String columnName, Clob x)
> updateBlob(int columnIndex, InputStream x, long length)
> updateBlob(String columnName, InputStream x, long length)
> updateClob(int columnIndex, Reader x, long length)
> updateClob(String columnName, Reader x, long length)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
