[
https://issues.apache.org/jira/browse/DERBY-2646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kristian Waagan updated DERBY-2646:
-----------------------------------
Attachment: derby-2646-04a-storestreamclob_utf8util.stat
derby-2646-04a-storestreamclob_utf8util.diff
'derby-2646-04a-storestreamclob_utf8util.diff' includes the following changes:
A java/engine/org/apache/derby/impl/jdbc/StoreStreamClob.java
Added StoreStreamClob, which implements InternalClob. It represents
a Clob on top of a stream from store, and is read-only.
M java/engine/org/apache/derby/impl/jdbc/InternalClob.java
Modified JavaDoc. An important aspect of some of the methods is only
described by the JavaDoc, it is not possible to see from the method
signature alone. This is that EOFException is thrown if the position
is larger than the length of the Clob. Should the signature include
both EOFException and IOException in the throws-clause?
A java/engine/org/apache/derby/iapi/util/UTF8Util.java
Created a utility class for operations on byte streams encoded as
UTF-8. Currently only a few skip methods are in there. The goal of
this class is to centralize the error-prone activity of decoding
UTF-8 encoded streams. Please review!
The main internal method does look a bit verbose to me, but I don't
think it is worth trimming down and "obfuscating" it until it is
shown to have performance problems.
Again, none of this code is enabled. This will happen in the next patch,
where EmbedClob and StoreStreamControl will be modified. There will also
be a separate patch for additional tests.
I expect to commit this code really fast.
> Cleanup of Clob control/support structures
> ------------------------------------------
>
> Key: DERBY-2646
> URL: https://issues.apache.org/jira/browse/DERBY-2646
> Project: Derby
> Issue Type: Sub-task
> Components: JDBC
> Affects Versions: 10.3.0.0
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Fix For: 10.3.0.0
>
> Attachments: derby-2646-01a_trailing_space.diff,
> derby-2646-01a_trailing_space.stat, derby-2646-02a-clob-reorg.diff,
> derby-2646-02a-clob-reorg.stat, derby-2646-03a-internalclob.diff,
> derby-2646-04a-storestreamclob_utf8util.diff,
> derby-2646-04a-storestreamclob_utf8util.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
