[ 
https://issues.apache.org/jira/browse/DERBY-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12567806#action_12567806
 ] 

Daniel John Debrunner commented on DERBY-1387:
----------------------------------------------

> My (badly worded) point was rather that the FS mentions 
>    org.apache.derby.impl.services.mbeans.BasicManagementService.java 
> in the case where JMX is available, but nothing about 
>    org.apache.derby.impl.services.mbeans.NoManagementService
> in the opposite case :)

Ahhh, wasn't expecting those classes to be in the functional spec, since they 
are implementation details.

I changed these names (from patch 9 & hence the functional spec) in the simple 
patch:

o.a.d.jmx -> o.a.d.mbeans  (public api)

o.a.d.iapi.services.mbeans -> o.a.d.iapi.services.jmx
o.a.d.impl.services.mbeans -> o.a.d.iapi.services.jmx

Rationale is that the derby internal code is really dealing with jmx and the 
public api is exposing mbeans.

BasicManagementService -> JMXManagementService

Rationale is that the name gives a better indication of its function (never did 
like the BasicXXX style in Derby)

jmxnone.NoManagementService - is a an none functional implementation of 
(Derby's internal) ManagementService api. It's there to support environments 
that do not have JMX. Implementing it as an empty class makes the management 
service module use the existing functionality for handling different 
environments rather than having special code in the monitor.

> Add JMX extensions to Derby
> ---------------------------
>
>                 Key: DERBY-1387
>                 URL: https://issues.apache.org/jira/browse/DERBY-1387
>             Project: Derby
>          Issue Type: New Feature
>          Components: Services
>            Reporter: Sanket Sharma
>            Assignee: John H. Embretsen
>         Attachments: DERBY-1387-1.diff, DERBY-1387-1.stat, DERBY-1387-2.diff, 
> DERBY-1387-2.stat, DERBY-1387-3.diff, DERBY-1387-3.stat, DERBY-1387-4.diff, 
> DERBY-1387-4.stat, DERBY-1387-5.diff, DERBY-1387-5.stat, DERBY-1387-6.zip, 
> DERBY-1387-7.zip, DERBY-1387-8.zip, DERBY-1387-9.diff, DERBY-1387-9.stat, 
> derby1387_simple_9_1.txt, derbyjmx.patch, jmx.diff, jmx.stat, 
> jmxFuncspec.html, jmxFuncspec.html, jmxFuncspec.html, Requirements for JMX 
> Updated.html, Requirements for JMX.html, Requirements for JMX.zip
>
>
> This is a draft requirement specification for adding monitoring and 
> management extensions to Apache Derby using JMX. The requirements document 
> has been uploaded on JIRA as well as the Derby Wiki page at 
> http://wiki.apache.org/db-derby/_Requirement_Specifications_for_Monitoring_%26_Management_Extensions_using_JMX
> Developers and Users are requested to please look at the document (feature 
> list in particular) and add their own rating to features by adding a coloumn 
> to the table.
> Comments are welcome.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to