[
https://issues.apache.org/jira/browse/DERBY-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12567771#action_12567771
]
Thomas Nielsen commented on DERBY-1387:
---------------------------------------
Before reading the complete jira, I did a quick, unbiased read of the FuncSpec
v2.1 and had a peek at the simplified v9 patch Dan posted, and put together
some minor comments:
- Whenever started on a non-JMX capable platform, the funcspec says "Derby will
start with the Management Service disabled." The patch still has a service
called "jmxnone". This service should probably be mentioned in the Agent Level
section along with the services that are there when JMX is available.
- Using the Platform MBeanserver and Standard MBeans is the way to go. To my
knowledge using these will also cater for future MXBeans. Good choices!
- Version MBean:
o Alpha should probably be renamed to isAlpha to align with isBeta?
o MaintVersion should probably be written out to MaintenanceVersion?
- MDatabaseMBean:
o The first 'M' seems to break the naming scheme used for the other MBeans?
No explaination for this deviation is given in the FS. Leftover from the
Commons Modeller "Model MBean" that was once rejected?
o addDBUser() will delete a user too according to the FS, so the name should
probably be changed to manageDBUser() or similar?
On skimming the complete Jira afterwards, I see some of my initial comments on
the MDatabaseMBean have already been raised by others.
> Add JMX extensions to Derby
> ---------------------------
>
> Key: DERBY-1387
> URL: https://issues.apache.org/jira/browse/DERBY-1387
> Project: Derby
> Issue Type: New Feature
> Components: Services
> Reporter: Sanket Sharma
> Assignee: John H. Embretsen
> Attachments: DERBY-1387-1.diff, DERBY-1387-1.stat, DERBY-1387-2.diff,
> DERBY-1387-2.stat, DERBY-1387-3.diff, DERBY-1387-3.stat, DERBY-1387-4.diff,
> DERBY-1387-4.stat, DERBY-1387-5.diff, DERBY-1387-5.stat, DERBY-1387-6.zip,
> DERBY-1387-7.zip, DERBY-1387-8.zip, DERBY-1387-9.diff, DERBY-1387-9.stat,
> derby1387_simple_9_1.txt, derbyjmx.patch, jmx.diff, jmx.stat,
> jmxFuncspec.html, jmxFuncspec.html, jmxFuncspec.html, Requirements for JMX
> Updated.html, Requirements for JMX.html, Requirements for JMX.zip
>
>
> This is a draft requirement specification for adding monitoring and
> management extensions to Apache Derby using JMX. The requirements document
> has been uploaded on JIRA as well as the Derby Wiki page at
> http://wiki.apache.org/db-derby/_Requirement_Specifications_for_Monitoring_%26_Management_Extensions_using_JMX
> Developers and Users are requested to please look at the document (feature
> list in particular) and add their own rating to features by adding a coloumn
> to the table.
> Comments are welcome.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
