[
https://issues.apache.org/jira/browse/DERBY-3829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Myrna van Lunteren updated DERBY-3829:
--------------------------------------
Attachment: DERBY-3829_m5.diff
Attaching a new patch (DERBY-3829_m5.diff) which attempts to address the
permissions problem I saw on windows.
Turns out sysinfo needs read access to org.apache.derby.info.DBMS.properties.
If we're using jars, that's in derby.jar, and I guess permission is already
granted (I didn't double check that, it seemed logical).
I struggled for a while trying to grant java.io.FilePermission read to
$derbyTesting.codeclasses, but that one uses the actual OS's file separator and
the FilePermission needs the forward slash - or so it seemed empirically.
So the latest patch adds a property to just the SysinfoTest.policy and wraps
that property into a SystemProperty Setup around the test's networkserver
setup if we're using classes.
I think there are some other tests that just return an empty suite if we're
running with classes for similar reasons, but I thought it worthwhile to make
it work as we're already using a decidated policy file.
I svn updated before building this patch and tried to incorporate the recent
changes to BaseTestCase.assertExecJavaCmdOK, but I wasn't quite sure that all
intended changes were in or not, so a review will be appreciated.
I ran suites.All with jars on linux (no problems), and with classes on
windows...On windows I ran twice and got some strange what looked like
cleanup-related errors the first time around, especially in the upgrade
tests...(warnings like, table already exist etc), but they didn't show up a
second time...
All in all, if there are no further suggestions, I'd like to commit this latest
variation on Erlend's work...
> Convert derbynet/sysinfo and derbynet/sysinfo_with_properties to JUnit
> ----------------------------------------------------------------------
>
> Key: DERBY-3829
> URL: https://issues.apache.org/jira/browse/DERBY-3829
> Project: Derby
> Issue Type: Test
> Components: Test
> Affects Versions: 10.5.0.0
> Reporter: Erlend Birkenes
> Assignee: Erlend Birkenes
> Priority: Minor
> Fix For: 10.5.0.0
>
> Attachments: Derby-3829_1.diff, Derby-3829_2.diff,
> DERBY-3829_m3.diff, DERBY-3829_m5.diff
>
>
> I'm guessing these two can be combined into one file
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
