[
https://issues.apache.org/jira/browse/DERBY-3420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12665382#action_12665382
]
Knut Anders Hatlen commented on DERBY-3420:
-------------------------------------------
I'm not sure I see why this has to be removed. The issue description says that
it's no longer needed, but it doesn't say which alternatives the users have or
why it's bad to have alternatives. I'm not saying that we shouldn't remove the
option, just that I don't fully understand why it should be removed.
If we remove the code, I guess we should also remove the connAttributeDefaults
variable/parameter from ij.Main.mainCore(), ij.Main.go() and ij.utilMain.go()
(it's always null now). I think the utilMain.connAttributeDefaults variable is
also always null, so it can be removed too, together with
utilMain.getConnectionAttributeDefaults(). Same goes for this section in ij.jj:
// If no ATTRIBUTES on the connection get them from the
// defaults
if (connInfo == null)
connInfo = util.updateConnInfo(userS,passwordS,
utilInstance.getConnAttributeDefaults());
else
connInfo = util.updateConnInfo(userS,passwordS,
connInfo);
which can be replaced with
connInfo = util.updateConnInfo(userS, passwordS, connInfo);
> The -ca option should be removed from ij and from the ij command usage line
> ---------------------------------------------------------------------------
>
> Key: DERBY-3420
> URL: https://issues.apache.org/jira/browse/DERBY-3420
> Project: Derby
> Issue Type: Bug
> Components: Tools
> Affects Versions: 10.3.2.1
> Reporter: Kim Haase
> Assignee: Bryan Pendleton
> Priority: Minor
> Attachments: removeObsoleteArg.diff
>
>
> The ij tool gives the following help output:
> Usage: java org.apache.derby.tools.ij [-p propertyfile] [-ca
> connectionAttributePropertyFile] [inputfile]
> The -ca connectionAttributePropertyFile option is no longer needed and is
> deprecated, so it is not documented in the Tools Guide. The option should
> also be removed from the usage statement.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
