[ 
https://issues.apache.org/jira/browse/DERBY-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12689302#action_12689302
 ] 

Tiago R. Espinha commented on DERBY-3842:
-----------------------------------------

I attached a patch although I believe it will not be the final one yet.

A few corrections to myself after having talked with Kathey:

- This patch makes use of a single table, populated on decorateSQL. This might 
not be a good plan in the end, as one of the tests adds data to the table. Then 
again, the data that is added does not interfere with the data that the other 
two tests need - so is it wise to leave it as it is?

All in all, it is order-independent even if one of the tests INSERTs into the 
table.

- This patch is now looking at both the value of "a" and the actual data, 
instead of the row number. I had misunderstood Mamta. What was being done 
before was that we were looking at the cursor's row number. I switched this 
behaviour to look at the data in the table instead, like the original test did.

Finally, this patch is largely based on Junjie's work (lots of copy-paste and 
adaptations), so it is be possible that I have missed something.

Any thoughts or comments are appreciated. I'll post here the results of the 
test running once I have them.

> Convert 
> "org.apache.derbyTesting.functionTests.tests.store.holdCursorExternalSortJDBC30.sql"
>  to junit.
> ------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-3842
>                 URL: https://issues.apache.org/jira/browse/DERBY-3842
>             Project: Derby
>          Issue Type: Test
>          Components: Test
>            Reporter: Junjie Peng
>            Assignee: Tiago R. Espinha
>         Attachments: derby-3842-1.patch, derby-3842-1.stat, 
> derby-3842-tiago.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to