[ 
https://issues.apache.org/jira/browse/DERBY-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12689902#action_12689902
 ] 

Bryan Pendleton commented on DERBY-3842:
----------------------------------------

I don't think the precise location of the commit or of the sort buffer size 
matters, because the sorting occurs before
the first record has been retrieved, so as long as the commit is after the 
first record has
been retrieved, whether the overflow-to-disk occurred on the 4th or 5th record 
doesn't really matter.

What matters is that the commit doesn't close and release the temporary sorted 
records; that
would cause some sort of internal error fetching records after the commit if it 
occurred.

Ideally, the test would verify that the sort actually *did* overflow to disk; I 
think there is some
information in the runtime statistics that will prove this. You could also 
verify that external
sorting occurred by watching the sorter's behavior in the debugger, I suppose.

> Convert 
> "org.apache.derbyTesting.functionTests.tests.store.holdCursorExternalSortJDBC30.sql"
>  to junit.
> ------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-3842
>                 URL: https://issues.apache.org/jira/browse/DERBY-3842
>             Project: Derby
>          Issue Type: Test
>          Components: Test
>            Reporter: Junjie Peng
>            Assignee: Tiago R. Espinha
>         Attachments: derby-3842-1.patch, derby-3842-1.stat, 
> derby-3842-tiago.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to