[ 
https://issues.apache.org/jira/browse/DERBY-4217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12707800#action_12707800
 ] 

Tiago R. Espinha commented on DERBY-4217:
-----------------------------------------

I have hit a speedbump with this issue. I have taken Kathey's advice and now 
those tests are no longer a problem. However there's a new issue.

The issue in question has to do with the ScriptTests. Basically, some of the 
.sql files that are ran as part of a ScriptTestCase, have the port hardcoded 
right on the .sql file (e.g. connect 
'jdbc:derby://localhost:1527/testij;create=true' USER 'dbadmin' PASSWORD 
'dbadmin').

I have been thinking about how to overcome this, but the solution I had thought 
of is far from ideal and I have had issues trying to implement it. My idea was 
to change the port references to a '<port>' placeholder, and then replace the 
<port> occurrences with the actual port. This however is complicated.

If I was to replace the ports on the actual files, then the first test run 
would be okay, but the consequent ones would not have the '<port>' placeholder; 
instead, they'd have the port from the previous run. Not good.

My idea was to make a temporary copy of the file, replace it on that file, and 
have the test run upon that sql file. This would also have to be done to the 
canon file (.out). When the test is done, the file is deleted.

I started implementing this last solution, but I'm running into so many 
problems (with permissions to copy the files, etc) that I thought I'd gather 
some opinions here first. Maybe there's an easier way to go about this.

Any thoughts?

> Make the default port for the suites.All run configurable with a system 
> property.
> ---------------------------------------------------------------------------------
>
>                 Key: DERBY-4217
>                 URL: https://issues.apache.org/jira/browse/DERBY-4217
>             Project: Derby
>          Issue Type: Sub-task
>    Affects Versions: 10.6.0.0
>            Reporter: Tiago R. Espinha
>            Assignee: Tiago R. Espinha
>         Attachments: DERBY-4217.patch, DERBY-4217.patch, DERBY-4217.patch, 
> DERBY-4217.stat, ReproNetworkServerControl.java
>
>
> The goal is to make the port used for suites.All configurable through a 
> system property passed on to the JVM.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to