[
https://issues.apache.org/jira/browse/DERBY-4217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12710924#action_12710924
]
Kathey Marsden commented on DERBY-4217:
---------------------------------------
>From a functional perspective, when tests are run, we want the value set by
>derby.tests.port to override the 1527 setting. Ultimately I think we will
>need three system properties derby.tests.port, derby.tests.alternativePort
>(currently used by NSinSameJVMTest) and derby.tests.replicationPort.
The question becomes "Where do we want to process these system properties?",
in TestConfiguration itself or in the code that calls the TestConfiguration
constructor with the port argument? For example this is some code from
ReplicationTestRun which ultimately calls the TestConfiguration constructor
with the port. It looks like someone already tried to partially implement this
system property business before, so things look a bit tangled up.
String masterHostName = System.getProperty("test.serverHost", "localhost");
int masterPortNo =
Integer.parseInt(System.getProperty("test.serverPort", "1527"));
suite.addTest(StandardTests.simpleTest(masterHostName, masterPortNo));
System.out.println("*** Done
suite.addTest(StandardTests.simpleTest())");
Let me study this a bit and get back to you tomorrow with a recommended
approach. Meanwhile if anyone else wants to jump in, suggestions are welcome.
> Make the default port for the suites.All run configurable with a system
> property.
> ---------------------------------------------------------------------------------
>
> Key: DERBY-4217
> URL: https://issues.apache.org/jira/browse/DERBY-4217
> Project: Derby
> Issue Type: Sub-task
> Affects Versions: 10.6.0.0
> Reporter: Tiago R. Espinha
> Assignee: Tiago R. Espinha
> Attachments: DERBY-4217.patch, DERBY-4217.patch, DERBY-4217.patch,
> DERBY-4217.patch, DERBY-4217.stat, DERBY-4217.stat,
> ReproNetworkServerControl.java
>
>
> The goal is to make the port used for suites.All configurable through a
> system property passed on to the JVM.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
