[ 
https://issues.apache.org/jira/browse/DERBY-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12892964#action_12892964
 ] 

Lily Wei commented on DERBY-4715:
---------------------------------

Thank you for reviewing the patch, Kristian. I will prefer using spaces for 
indentation as well.
However, for file BaseDataFileFactory.java, there are way too many lines 
changes if I save spaces as tab for indentation using editor/IDE to insert 
spaces when I press the TAB key. That is why both spaces and tab were using for 
the patch. I think it is also important to keep history as we introduce insert 
spaces as tab for indentation going forward. We could have a project that only 
changes tab to spaces.

> Write jvm information and path of derby.jar to derby.log
> --------------------------------------------------------
>
>                 Key: DERBY-4715
>                 URL: https://issues.apache.org/jira/browse/DERBY-4715
>             Project: Derby
>          Issue Type: Bug
>          Components: Miscellaneous
>    Affects Versions: 10.6.1.0
>            Reporter: Lily Wei
>            Assignee: Lily Wei
>            Priority: Minor
>             Fix For: 10.7.0.0
>
>         Attachments: DERBY-4715-1.diff, DERBY-4715-2.diff, DERBY-4715-3.diff, 
> DERBY-4715-4.diff, DERBY-4715-5.diff, DERBY-4715-6.diff, DERBY-4715-7.diff, 
> DERBY-4715-8.diff, derby.log
>
>
> The bug is part of DERBY-1272. In production environment, derby.jar can be 
> located different than the derbyclient.jar It can be easier if we have jvm 
> version information and path of derby.jar are in the derby.log

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to