[
https://issues.apache.org/jira/browse/DERBY-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12893091#action_12893091
]
Kristian Waagan commented on DERBY-4715:
----------------------------------------
Yes, I agree that we should not change the indentation for lines we don't touch
in a patch. My point was about lines added or changed as part of a patch.
Due to better tools this mixing of tabs and spaces isn't such a big deal any
more, but still the tools mess up at times (for instance changing the
indentation on lines not changed by the fix itself, or when viewing diffs/code
in a terminal).
For the curious, here's where we stand today:
Whitespace characteristics (r967304)
==================================
* Files
Spaces only : 1056 37.34%
Tabs only : 0 0.00%
Mixed : 1772 62.66%
* Lines
Spaces only : 597974 52.23%
Tabs only : 281128 24.55%
Mixed : 87550 7.65%
Blank : 131378 11.47%
No indent : 46943 4.00%
We can see that even changing just the lines which mix both tabs and spaces
would cause a huge amount of noise (and, as you say, make digging in the Derby
history more difficult), which is why I'm most comfortable with just letting
the situation improve gradually. Then, in a rather distant future... ;)
> Write jvm information and path of derby.jar to derby.log
> --------------------------------------------------------
>
> Key: DERBY-4715
> URL: https://issues.apache.org/jira/browse/DERBY-4715
> Project: Derby
> Issue Type: Bug
> Components: Miscellaneous
> Affects Versions: 10.6.1.0
> Reporter: Lily Wei
> Assignee: Lily Wei
> Priority: Minor
> Fix For: 10.7.0.0
>
> Attachments: DERBY-4715-1.diff, DERBY-4715-2.diff, DERBY-4715-3.diff,
> DERBY-4715-4.diff, DERBY-4715-5.diff, DERBY-4715-6.diff, DERBY-4715-7.diff,
> DERBY-4715-8.diff, derby.log
>
>
> The bug is part of DERBY-1272. In production environment, derby.jar can be
> located different than the derbyclient.jar It can be easier if we have jvm
> version information and path of derby.jar are in the derby.log
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
