I strongly support to that suggestion as it improves the design!
2014-03-05 16:23 GMT+08:00 Jared Zimmerman <[email protected]>: > Honestly I don't think cancel should be destructive. I think "discard > changes" should. But currently we don't change the button text after the > user has made changes. Someone want to log that bug, should be simple since > there are other actions that listen for changes to the text box to trigger > a "are you sure you want to navigate away from this page" if changes have > been made. > > Sent while mobile > > On Mar 5, 2014, at 12:20 AM, Matthew Flaschen <[email protected]> > wrote: > > The current proposed change to use mw-ui-button for save/preview/show > changes/cancel (on the edit screen) uses mw-ui-destructive (with quiet) for > the cancel button. This directly contradicts the style guide, which says, > "This should not be used for cancel buttons.". > > As noted at https://gerrit.wikimedia.org/r/#/c/116725/ , my understanding > of destructive is that you are deleting something that was already publicly > visible, or at least has an impact beyond your own personal session. > > The cancel button doesn't seem to fit that. Cancel is a common concept, > and semantically clear, so perhaps we should simply add mw-ui-cancel. > > Matt Flaschen > > _______________________________________________ > Design mailing list > [email protected] > https://lists.wikimedia.org/mailman/listinfo/design > > _______________________________________________ > Design mailing list > [email protected] > https://lists.wikimedia.org/mailman/listinfo/design >
_______________________________________________ Design mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/design
