Brian:
Brian Cameron-san wrote (01/21/09 11:48 AM):
>> I meant to modify Xinitrc.[t]jds so that /etc/X11/xinit/xinitrc.d is
>> loaded. I.e.
>>
>> /usr/dt/config/Xsession.jds
>> -> /usr/dt/bin/Xsession
>> -> Load /usr/dt/config/Xsession.d
>> -> /usr/dt/config/Xinitrc.jds
>> -> Load /etc/X11/xinit/xinitrc.d
>
> I don't recommend doing this. Note if you want to change the way
> the /usr/dt scripts work, then you need to coordinate this change with
> the CDE team. It is very hard to get changes upstream into CDE, and
> they tend to push back changes that are not the highest priority.
I thought this again.
Probably the better approach is to move the l10n contents of Xinitrc.[t]jds
into /usr/dt/config/Xsession.d.
And then we can synchronize /usr/dt/config/Xsession.d and
/etc/X11/xinit/xinitrc.d.
Currently 0005.dbus has this way and l10n scripts also can be followed.
>
>> Currently the scripts in xinitrc.d have the duplicated contents of
>> Xinitrc.jds. So if we clean up Xinitrc.jds and the contents are moved
>> to xinitrc.d scripts, we can maintain xinitrc.d scripts only.
>
> I think managing duplicated contents is easier than trying to get
> the CDE team to accept any changes to their scripts, actually.
>
>> It means other sessions from dtlogin loads /usr/dt/config/Xsession.d
>> only and GNOME session loads both /usr/dt/config/Xsession.d and
>> /etc/X11/xinit/xinitrc.d.
>>
>> Otherwise, in case Xinitrc.[t]jds don't load /etc/X11/xinit/xinitrc.d
>> (as the current implementation), we need to think when we update the
>> scripts in /etc/X11/xinit/xinitrc.d.
>> e.g.
>> If we add a script in xinitrc.d, do we also copy the contents into
>> Xinitrc.[t]jds ?
>
> I would install the scripts to both locations. Each login program
> should use its own separate directory.
OK, I see.
> I think the best way to address this would be to fix the first-session
> login script to also source the /etc/X11/xinit/xinitrc.d scripts before
> it runs dtstart.
>
> It doesn't make sense to move the sourcing of the
> /etc/X11/xinit/xinitrc.d scripts into the dtstart script, because this
> would introduce two problems:
>
> 1) We'd need to patch GDM to not source the scripts in the Xsession
> script, and I'm not sure it is good to deviate from the community
> here.
> 2) When using CDE login, the scripts would get run twice.
>
> So, it seems better to just make the first-session login script do
> the same code. Note it only takes 7 lines of code in the
> /etc/X11/gdm/Xsession script to source these files, so it should not
> be a big deal to add the same code to another script.
I guess your suggestion needs to modify the installer package.
Why do we want to run dtstart from /etc/X11/gdm/Xsession and what is the
purpose of dtstart from GDM?
/etc/X11/gdm/Xsession
-> Load /etc/X11/xinit/xinitrc.d
-> dtstart
-> /usr/dt/config/Xinitrc.jds
I thought to clean up the content of dtstart.
> It probably would be better to add the dtstart script to the
> SUNWgnome-session package since the /usr/share/xsessions/gnome.desktop
> file is owned by SUNWgnome-session and it is calling the dtstart script.
> Right?
I mistook one thing.
SUNWgnome-dtlogin-integration and SUNWgnome-dtstart are exclusive packages in
the spec file.
So probably dtstart and xinitrc.d are included in SUNWgnome-dtlogin-integration
or SUNWgnome-session ?
>
> I don't see the need to rename dtstart to sun-desktop. Since we're
> already using the name dtstart in Indiana, why not keep things
> consistent?
I thought if we remove the dependencies of CDE from dtstart.
Yes, keeping the name is not a problem.
fujiwara
>
> Brian
>
