Takao: > I thought this again. > Probably the better approach is to move the l10n contents of > Xinitrc.[t]jds into /usr/dt/config/Xsession.d. > And then we can synchronize /usr/dt/config/Xsession.d and > /etc/X11/xinit/xinitrc.d. > Currently 0005.dbus has this way and l10n scripts also can be followed.
Right, I think this is the best way. >> So, it seems better to just make the first-session login script do >> the same code. Note it only takes 7 lines of code in the >> /etc/X11/gdm/Xsession script to source these files, so it should not >> be a big deal to add the same code to another script. > > I guess your suggestion needs to modify the installer package. > Why do we want to run dtstart from /etc/X11/gdm/Xsession and what is the > purpose of dtstart from GDM? > > /etc/X11/gdm/Xsession > -> Load /etc/X11/xinit/xinitrc.d > -> dtstart > -> /usr/dt/config/Xinitrc.jds > > I thought to clean up the content of dtstart. Yes, we should take the code from Xinitrc.jds and move it into a /etc/X11/xinit/xinitrc.d script and modify dtstart so it just runs gnome-session directly. Might be good to also move much of the Xinitrc.jds code to /usr/dt/config/Xsession.d and make Xinitrc.jds just simply start gnome-session and do nothing else. >> It probably would be better to add the dtstart script to the >> SUNWgnome-session package since the /usr/share/xsessions/gnome.desktop >> file is owned by SUNWgnome-session and it is calling the dtstart script. >> Right? > > I mistook one thing. > SUNWgnome-dtlogin-integration and SUNWgnome-dtstart are exclusive > packages in the spec file. > So probably dtstart and xinitrc.d are included in > SUNWgnome-dtlogin-integration or SUNWgnome-session ? Right, I'm suggesting we move dtstart into SUNWgnome-session, and get rid of the SUNWgnome-dtstart package. I think the reason we deliver this in a separate package is because it is currently Indiana only. Once we make GDM always run dtstart, it makes sense to integrate it into SUNWgnome-session. Though it would also be okay to deliver the dtstart script in its own SUNWgnome-dtstart package. Laca wrote all of this before we started talking about cleaning up these scripts, so would be good to include him in the discussion, and see what he thinks. >> I don't see the need to rename dtstart to sun-desktop. Since we're >> already using the name dtstart in Indiana, why not keep things >> consistent? > > I thought if we remove the dependencies of CDE from dtstart. > Yes, keeping the name is not a problem. Either way is okay with me, really. The main goal is just to clean up these scripts so that we maintain them more sensibly. Making use of the /usr/dt/config/Xsession.d and /etc/X11/xinit/xinitrc.d directories for running special configuration just is cleaner. Brian
