Launchpad has imported 20 comments from the remote bug at https://bugzilla.mozilla.org/show_bug.cgi?id=485472.
If you reply to an imported comment from within Launchpad, your comment will be sent to the remote bug automatically. Read more about Launchpad's inter-bugtracker facilities at https://help.launchpad.net/InterBugTracking. ------------------------------------------------------------------------ On 2009-03-27T02:06:43+00:00 Bastien Nocera wrote: User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en; rv:1.9.0.7) Gecko/20080528 Fedora/2.24.3-3.fc10 Epiphany/2.22 Firefox/3.0 Build Identifier: Untested patch below Reproducible: Always Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1100326/comments/0 ------------------------------------------------------------------------ On 2009-03-27T02:07:29+00:00 Bastien Nocera wrote: Created attachment 369611 mozilla-geoclue-for-location-1.patch Comments welcome Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1100326/comments/1 ------------------------------------------------------------------------ On 2009-03-27T02:11:45+00:00 Bastien Nocera wrote: Looks like I need to use the GeoclueMaster and GeoclueMasterClient APIs instead of hard-coding Gypsy, as WebKit did (https://bugs.webkit.org/show_bug.cgi?id=22022) Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1100326/comments/2 ------------------------------------------------------------------------ On 2009-03-27T14:16:59+00:00 Blizzard wrote: Bastien, is this ready for review? Sorry, I don't understand your second comment here. Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1100326/comments/3 ------------------------------------------------------------------------ On 2009-03-27T15:34:15+00:00 Bastien Nocera wrote: (In reply to comment #3) > Bastien, is this ready for review? Sorry, I don't understand your second > comment here. The current code will only work with GPS devices, and it's hard-coded. I need to update the patch to use a different API that will hide the providers (so it also works with hostip, etc.). So it's not ready for review just yet, though I'd appreciate any comments somebody could have about the current code. Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1100326/comments/4 ------------------------------------------------------------------------ On 2009-03-28T01:52:57+00:00 Bastien Nocera wrote: Created attachment 369792 mozilla-geoclue-for-location-2.patch Patch that (nearly) compiles, same as -1. Can't get past that error though: ../../staticlib/components/libgklayout.a(GeoclueLocationProvider.o): In function `GeoclueLocationProvider::Startup()': GeoclueLocationProvider.cpp:(.text+0x194): undefined reference to `geoclue_position_new' ../../staticlib/components/libgklayout.a(GeoclueLocationProvider.o): In function `location_changed(_GeocluePosition*, int, int, double, double, double, void*, void*)': GeoclueLocationProvider.cpp:(.text+0x216): undefined reference to `geoclue_accuracy_get_details' /usr/bin/ld: libxul.so: hidden symbol `geoclue_position_new' isn't defined /usr/bin/ld: final link failed: Nonrepresentable section on output collect2: ld returned 1 exit status -lgeoclue _is_ listed in the extra dso, but I believe something is missing for me to be able to finish the linking. I also don't believe the Maemo/liblocation backend would even compile, so not a great example to follow :) Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1100326/comments/5 ------------------------------------------------------------------------ On 2009-03-30T00:21:11+00:00 Doug-turner wrote: Marking new since support for geoclue is reasonable. However, what do you think of dynamically linking to geoclue so that we can build on systems that do not have geoclue? Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1100326/comments/6 ------------------------------------------------------------------------ On 2009-03-30T09:46:16+00:00 Bastien Nocera wrote: (In reply to comment #6) > > Marking new since support for geoclue is reasonable. However, what do you > think of dynamically linking to geoclue so that we can build on systems that > do > not have geoclue? I think it might be a bit early to do that. I don't think that Geoclue's got any guarantees of API stability just yet, and I would expect problems if it were to changes (which could be causing crashes in the front-ends). For now, I'd just fancy any hints to make it link properly, so that I can rework and test the code as mentioned in comment #2. Then using GModule it should be pretty straight forward to build without geoclue, but the support to still be enabled. Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1100326/comments/7 ------------------------------------------------------------------------ On 2009-03-31T11:30:31+00:00 Bastien Nocera wrote: Created attachment 370177 mozilla-geoclue-for-location-3.patch Ready for a first round of review. Note that you need to "rm dist/bin/components/TestGeolocationProvider.js" if you want to test this, otherwise you'll be in SF. I couldn't get geoclue to report anything interesting to me I'm afraid, though Gypsy (the GPS daemon) itself did work. If you want the code to be made run-time loadable before merging, please point me to the nspr way of doing this, otherwise I'll use GModule. Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1100326/comments/8 ------------------------------------------------------------------------ On 2009-06-20T12:15:43+00:00 Bastien Nocera wrote: Could I have a review on the existing code please? Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1100326/comments/9 ------------------------------------------------------------------------ On 2009-06-20T14:55:45+00:00 Doug-turner wrote: Comment on attachment 370177 mozilla-geoclue-for-location-3.patch needs to be marked for review. I will try to get to it this week. Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1100326/comments/10 ------------------------------------------------------------------------ On 2009-07-06T18:03:16+00:00 Doug-turner wrote: Comment on attachment 370177 mozilla-geoclue-for-location-3.patch I would have thought that bug 454490 would have landed by now. :-( And, i would have thought that i would have reviewed this bug already. Generally looks okay. How do I install geoclue on my ubuntu 9.04 box? separate out the build related stuff so that Ted can review it independently. white space is off. no tabs please. extra blank line after the return: + return; + if (!(fields & GEOCLUE_POSITION_FIELDS_LATITUDE && fields & GEOCLUE_POSITION_FIELDS_LONGITUDE)) local variables shouldn't be prefixed with "a". That convention is for in/inout vars If a location from geoclue doesn't have an accuracy, should the value given to the web really be 0? Also, i am unfamiliar with the geoclue api. I am making assumptions about your usage being correct. What is the best API documentation for geoclue? Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1100326/comments/11 ------------------------------------------------------------------------ On 2009-07-07T11:52:45+00:00 Bastien Nocera wrote: (In reply to comment #11) > (From update of attachment 370177 [details]) > I would have thought that bug 454490 would have landed by now. :-( And, i > would have thought that i would have reviewed this bug already. > > Generally looks okay. How do I install geoclue on my ubuntu 9.04 box? There's some packages available: http://packages.ubuntu.com/karmic/geoclue It should be pretty straight forward to recompile the package on your version of Ubuntu. I don't think the package is very up-to-date, so compiling from git is probably a good idea (it lives on freedesktop.org). > separate out the build related stuff so that Ted can review it independently. Will do. > white space is off. no tabs please. > > extra blank line after the return: > + return; > + if (!(fields & GEOCLUE_POSITION_FIELDS_LATITUDE && fields & > GEOCLUE_POSITION_FIELDS_LONGITUDE)) Will fix. > local variables shouldn't be prefixed with "a". That convention is for > in/inout vars OK. > If a location from geoclue doesn't have an accuracy, should the value given to > the web really be 0? To be honest, I don't know how the backend within Mozilla will behave in those cases. Accuracy should always be available when using most of the position providers, but I wouldn't be able to tell you whether it's the right thing to do. What does the HTML5 API tell us we should be using? > Also, i am unfamiliar with the geoclue api. I am making assumptions about > your > usage being correct. What is the best API documentation for geoclue? I had some Geoclue people look at the code, and they seemed happy with it. The API docs are available in geoclue itself, built from gtk-doc. Usually this lives in the devel package. FYI, I'm at GCDS and we're having a Geoclue BoF this afternoon, so we should be able to do some more work on the backend, and I'll ask people about the accuracy problem. Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1100326/comments/12 ------------------------------------------------------------------------ On 2009-07-07T16:50:58+00:00 Doug-turner wrote: if you say that accuracy is zero the Mozilla implementation will assume that this is the exact point that you are at and it will override everything. Maybe that is good for a user defined position. Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1100326/comments/13 ------------------------------------------------------------------------ On 2009-08-05T14:10:18+00:00 Neil-uy4g6 wrote: (In reply to comment #6) > > Marking new since support for geoclue is reasonable. However, what do you > think of dynamically linking to geoclue so that we can build on systems that > do > not have geoclue? Just a thought - instead of dynamically linking to libgeoclue, could it not just call the DBUS methods directly? Might work out a bit cleaner that way. Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1100326/comments/14 ------------------------------------------------------------------------ On 2009-08-27T20:40:35+00:00 Doug-turner wrote: dumb question -- does geoclue provide info to gpsd? Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1100326/comments/15 ------------------------------------------------------------------------ On 2009-08-27T20:43:17+00:00 Craig wrote: (In reply to comment #15) > dumb question -- does geoclue provide info to gpsd? No. Geoclue is an abstraction on top of gpsd, so really, gpsd provides info to geoclue. The point of Geoclue is that an application can ask for the present location, and not care if it came from cell tower triangulation, manual user input, gpsd, or something else entirely. Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1100326/comments/16 ------------------------------------------------------------------------ On 2010-01-15T17:51:29+00:00 Sonny Piers wrote: (In reply to comment #14) > Just a thought - instead of dynamically linking to libgeoclue, could it not > just call the DBUS methods directly? Might work out a bit cleaner that way. GeoClue provide more than D-Bus. "Geoclue is a modular geoinformation service built on top of the D-Bus messaging system. The goal of the Geoclue project is to make creating location-aware applications as simple as possible. " Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1100326/comments/17 ------------------------------------------------------------------------ On 2010-01-15T18:02:41+00:00 Ross Burton wrote: Yes, calling the DBus methods directly would be possible, libgeoclue is basically a convenience wrapper that makes the DBus calls. Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1100326/comments/18 ------------------------------------------------------------------------ On 2010-01-15T18:05:55+00:00 Bastien Nocera wrote: FWIW, I'm waiting until I have time to clean up geoclue itself before updating this patch. If somebody wants to do it in the meantime, feel free to go ahead. Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1100326/comments/19 ** Changed in: firefox Status: Unknown => Confirmed ** Changed in: firefox Importance: Unknown => Wishlist ** Bug watch added: bugs.webkit.org/ #22022 https://bugs.webkit.org/show_bug.cgi?id=22022 -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to chromium-browser in Ubuntu. https://bugs.launchpad.net/bugs/1100326 Title: Location requested by websites should be able to use GPS/mobile positioning Status in Chromium Browser: Fix Committed Status in The Mozilla Firefox Browser: Confirmed Status in GeoClue: The Geoinformation Service: Unknown Status in “chromium-browser” package in Ubuntu: New Status in “firefox” package in Ubuntu: New Status in “geoclue-providers” package in Ubuntu: New Bug description: It would be nice if location requested by websites could use location found from GPS or GSM/CDMA positioning. To manage notifications about this bug go to: https://bugs.launchpad.net/chromium-browser/+bug/1100326/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
