I applied this simple patch, but the tests still fail. The log output is hard to parse, I'm attaching it.
--- a/internal/testutils/samba.go +++ b/internal/testutils/samba.go @@ -18,7 +18,7 @@ func SetupSmb(port int, sysvolDir string) func() { dir, cleanup := mkSmbDirWithConf(smbPort, sysvolDir) // #nosec:G204 - we control the directory we run smbd on (on tests) - cmd := exec.Command("smbd", "-FS", "-s", filepath.Join(dir, "smbd.conf")) + cmd := exec.Command("smbd", "-F", "--debug-stdout", "-s", filepath.Join(dir, "smbd.conf")) stderr, err := cmd.StderrPipe() if err != nil { log.Fatalf("Setup: can’t get smb output: %v", err) ** Attachment added: "log" https://bugs.launchpad.net/ubuntu/+source/adsys/+bug/1962170/+attachment/5563894/+files/log -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to adsys in Ubuntu. https://bugs.launchpad.net/bugs/1962170 Title: DEP8 failure with samba 4.15.5 Status in adsys package in Ubuntu: In Progress Bug description: The DEP8 tests of adsys started to fail[1] with my samba 4.15.5 upload. Some hints: <didrocks> ahasenack: it seems we can’t start our smbd local daemon to simulate Active Directory smb server <didrocks> ahasenack: yeah, I’m puzzled because on smbd start failure, we do print stderr (not stdout though): https://github.com/ubuntu/adsys/blob/main/internal/testutils/samba.go#L16 <didrocks> https://github.com/ubuntu/adsys/blob/main/internal/testutils/samba.go#L43 in particular <didrocks> you can see here how we start it: https://github.com/ubuntu/adsys/blob/main/internal/testutils/samba.go#L21 <didrocks> and the config template is at https://github.com/ubuntu/adsys/blob/20e6f962eb87f667f5e29800be0715ab2496a10d/internal/testutils/samba.go#L55 <ahasenack> 2022/02/24 03:13:59 Setup: smbd hasn’t started successfully <ahasenack> that's here: https://github.com/ubuntu/adsys/blob/main/internal/testutils/samba.go#L129 <ahasenack> you wait for the port to be open? <ahasenack> which port is that, 445/tcp? <didrocks> we wait on the port to be opened, and this one is passed as a parameter, see the template. For the argument we pass in ad tests, once sec, looking <didrocks> 1446 <didrocks> https://github.com/ubuntu/adsys/blob/20e6f962eb87f667f5e29800be0715ab2496a10d/cmd/integration_tests/adsys_test.go#L47 <didrocks> you just need to run go test . in internal/ad/ <didrocks> the failure is as the pre-test setup 1. https://autopkgtest.ubuntu.com/results/autopkgtest-jammy/jammy/amd64/a/adsys/20220224_031434_4d453@/log.gz To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/adsys/+bug/1962170/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp