Hum, it seems your patch makes sense and should work on most arch. I saw 
Michael did an upload with this: 
https://launchpad.net/ubuntu/+source/adsys/0.8ubuntu1
But it’s failing only on ppcel64: 
https://launchpadlibrarian.net/588289907/buildlog_ubuntu-jammy-ppc64el.adsys_0.8ubuntu1_BUILDING.txt.gz
 and passing on other architectures.

The issue may be related to the signal installed on libsmbclient: 
https://github.com/ubuntu/adsys/blob/main/internal/smbsafe/smbsafe.go#L4. This 
workaround is the only reason of smbsafe (you can’t then exec concurrently 
subprocesses without cleaning up those signals and the library is doing that at 
every smb call on your behalf).
Another idea is that stderr is not allocated for whatever reason 
https://github.com/ubuntu/adsys/blob/main/internal/testutils/samba.go#L38 but 
why only on ppcel64?

I reastically won’t have the time this week with the sprint to look at
this. I hope this gives some hints if you need urgently to have it fixed
before next one.

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to adsys in Ubuntu.
https://bugs.launchpad.net/bugs/1962170

Title:
  DEP8 failure with samba 4.15.5

Status in adsys package in Ubuntu:
  In Progress

Bug description:
  The DEP8 tests of adsys started to fail[1] with my samba 4.15.5
  upload.

  Some hints:

  <didrocks> ahasenack: it seems we can’t start our smbd local daemon to
  simulate Active Directory smb server


  <didrocks> ahasenack: yeah, I’m puzzled because on smbd start failure, we do 
print stderr (not stdout though): 
https://github.com/ubuntu/adsys/blob/main/internal/testutils/samba.go#L16
  <didrocks> 
https://github.com/ubuntu/adsys/blob/main/internal/testutils/samba.go#L43 in 
particular
  <didrocks> you can see here how we start it: 
https://github.com/ubuntu/adsys/blob/main/internal/testutils/samba.go#L21
  <didrocks> and the config template is at 
https://github.com/ubuntu/adsys/blob/20e6f962eb87f667f5e29800be0715ab2496a10d/internal/testutils/samba.go#L55
  <ahasenack> 2022/02/24 03:13:59 Setup: smbd hasn’t started successfully
  <ahasenack> that's here: 
https://github.com/ubuntu/adsys/blob/main/internal/testutils/samba.go#L129
  <ahasenack> you wait for the port to be open?
  <ahasenack> which port is that, 445/tcp?
  <didrocks> we wait on the port to be opened, and this one is passed as a 
parameter, see the template. For the argument we pass in ad tests, once sec, 
looking
  <didrocks> 1446
  <didrocks> 
https://github.com/ubuntu/adsys/blob/20e6f962eb87f667f5e29800be0715ab2496a10d/cmd/integration_tests/adsys_test.go#L47

  
  <didrocks> you just need to run go test . in internal/ad/
  <didrocks> the failure is as the pre-test setup

  
  1. 
https://autopkgtest.ubuntu.com/results/autopkgtest-jammy/jammy/amd64/a/adsys/20220224_031434_4d453@/log.gz

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/adsys/+bug/1962170/+subscriptions


-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to     : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp

Reply via email to