Thanks for the patch, Aaron. I'm able to reproduce this bug using the
firefox f11 -> open link in new window, when using the live session of
the daily-live lubuntu iso.  And the attached patch does seem to help.

Overall the patch is what I was hoping to see, but I will request some
changes.

* The Maintainer field currently reads "Maintainer: Lubuntu
  Developers".  I'd like you to go with the more conventional "Ubuntu
  Developers" attribution. `seeded-in-ubuntu` says that openbox is
  also used in Ubuntu Mate, and of course people can use openbox
  otherwise. The `update-maintainer` script is a convenient way to set
  this field to the value I'm suggesting (when starting from the
  original value).
* There is a sponsorship process listed on the wiki, I think
  https://wiki.ubuntu.com/MOTU/Sponsorship/SponsorsQueue is a good
  summary. This can also help, in the future, find someone to take a
  look at the patch as doing so means your work show up in the queue.
  http://reports.qa.ubuntu.com/reports/sponsoring/
  Since I'm already looking at this I won't demand the SponsorsQueue
  bug changes but please keep that in mind for the next one.
* I forget where I saw it but I like the convention that the patch has
  a change number, like it looks like you're on v4 of the patch.  So
  it might have been called glib_crash_bugfix-v4.patch or something.
  A nice convention for when these keep changing.
* One item also mentioned on the wiki is forwarding this patch to
  Debian.  It is likely that the same problem applies there.
  https://wiki.ubuntu.com/Debian/Bugs talks about this in detail.
  I will ask that you do this before upload.  For this particular bug
  I'd feel comfortable sharing the patch with Debian without
  reproducing on Debian, since it's already known to be happening
  elsewhere.  Just say so when forwarding.
* A tweak to the changelog would be nice.  It isn't necessary to note
  the update to the maintainer field, that will be the case for most
  if not all packages with an Ubuntu delta.  Also, the first segment
  about the patch is in my opinion too developer focused.  I'd
  probably start with "Cherry-pick patch from A for crash issue when
  B + C happens", fill in appropriate details you think might be
  interesting for someone who might not look at the code.

So Maintainer + Debian + Changelog tweaks and I will be happy to
upload.

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to glib2.0 in Ubuntu.
https://bugs.launchpad.net/bugs/2011751

Title:
  openbox crashed with SIGABRT

Status in glib2.0 package in Ubuntu:
  Invalid
Status in openbox package in Ubuntu:
  Confirmed

Bug description:
  Lubuntu lunar (primary box) on
  - dell [optiplex] 7050 (i5-6500, 16gb, intel hd530/i915)

  I experienced a crash yesterday (openbox) but tend to ignore the first
  crashes... Whilst using the machine again today a crash occurred.

  This is my primary box, so my setup is pretty consistent

  - featherpad (restored session)
  - hexchat (irc)
  - qterminal (only single tab today; usually many)
  - firefox (snap, most sites excluding google related)
  - chromium (snap, used for anything google related)
  - telegram (snap)
  - element

  I was using chromium full screen (trying to read my gmail inbox) when
  borders around windows disappeared & I lost the capacity to switch
  between windows; mouse would move, but keyboard appeared mostly dead
  (it wasn't, more I think windows weren't responding, inc. clicks with
  mouse though that's likely inconsistent; I could [not] work out how to
  describe it yesterday, but todays is almost identical).

  I switched to text terminal (ctrl+alt+f4) & explored; returned to GUI and used
  - ctrl+alt+t to open new terminal
  - openbox &

  session returned to what I expect...

  ** expected outcome

  Openbox doesn't crash

  ** actual outcome

  all windows lost borders, and i lost ability to switch between windows
  I appeared to have minimal control (not true, more a fraction of what I 
expect)

  ** How to get crash

  For me,

  - I used chromium (browser)
  - make chromium full screen (ie. F11)
  - click on link/something & right-click to open in new window
  OPENBOX CRASH.

  ProblemType: Crash
  DistroRelease: Ubuntu 23.04
  Package: openbox 3.6.1-10
  ProcVersionSignature: Ubuntu 6.1.0-16.16-generic 6.1.6
  Uname: Linux 6.1.0-16-generic x86_64
  ApportVersion: 2.26.0-0ubuntu2
  Architecture: amd64
  CasperMD5CheckResult: unknown
  CrashCounter: 1
  CurrentDesktop: LXQt
  Date: Thu Mar 16 09:46:22 2023
  ExecutablePath: /usr/bin/openbox
  ExecutableTimestamp: 1643543619
  InstallationDate: Installed on 2023-01-25 (49 days ago)
  InstallationMedia: Lubuntu 23.04 "Lunar Lobster" - Alpha amd64 (20230124)
  JournalErrors: -- No entries --
  ProcCmdline: /usr/bin/openbox
  ProcCwd: /home/guiverc
  RebootRequiredPkgs: Error: path contained symlinks.
  Signal: 6
  SourcePackage: openbox
  StacktraceTop:
   () at /lib/x86_64-linux-gnu/libobt.so.2
   <signal handler called> () at /lib/x86_64-linux-gnu/libc.so.6
   client_calc_layer ()
   ()
   () at /lib/x86_64-linux-gnu/libobt.so.2
  UpgradeStatus: No upgrade log present (probably fresh install)
  UserGroups: adm cdrom dip lpadmin plugdev sambashare sudo
  separator:

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/glib2.0/+bug/2011751/+subscriptions


-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to     : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp

Reply via email to