[ 
https://issues.apache.org/jira/browse/PDFBOX-5863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17872660#comment-17872660
 ] 

Lars Torunski commented on PDFBOX-5863:
---------------------------------------

But the comparisons

{{header[1] == 0x01 || header[1] == 0x02}}

without (byte) ae OK?

> bad comparison of byte with 128
> -------------------------------
>
>                 Key: PDFBOX-5863
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-5863
>             Project: PDFBox
>          Issue Type: Bug
>          Components: PDModel
>    Affects Versions: 3.0.2 PDFBox
>            Reporter: Dieter von Holten
>            Assignee: Tilman Hausherr
>            Priority: Major
>             Fix For: 3.0.3 PDFBox, 4.0.0
>
>
> inspection by spotbugs shows a problem in 
> o.a.padfbox.pdmodel.font.FontFactory line 285:
> the partial expression {{header[0] == 0x80 && ...}}
> is always false. The code should be{{ header[0] == (byte) 0x80 && ...}}
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

Reply via email to