[ https://issues.apache.org/jira/browse/PDFBOX-5863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17872665#comment-17872665 ]
Tilman Hausherr commented on PDFBOX-5863: ----------------------------------------- 1 and 2 stay 1 and 2 in conversion. Byte values > 0x7f become negative numbers in conversion, that's the problem. > bad comparison of byte with 128 > ------------------------------- > > Key: PDFBOX-5863 > URL: https://issues.apache.org/jira/browse/PDFBOX-5863 > Project: PDFBox > Issue Type: Bug > Components: PDModel > Affects Versions: 3.0.2 PDFBox > Reporter: Dieter von Holten > Assignee: Tilman Hausherr > Priority: Major > Fix For: 3.0.3 PDFBox, 4.0.0 > > > inspection by spotbugs shows a problem in > o.a.padfbox.pdmodel.font.FontFactory line 285: > the partial expression {{header[0] == 0x80 && ...}} > is always false. The code should be{{ header[0] == (byte) 0x80 && ...}} > > -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org