If my git fu is correct, we only landed 180 patches with sr=. In 2009, we landed 1033 patches with super review. Of the sr= that landed in the last year, most were sr’ed by people from the DOM team (olli, sicking, blake, bz, sicking, sicking, sicking).
I tend to think that super review is a dumb idea. I don’t think we need any new module level system for dealing with .webidl changes. A DOM peer is required. This group can impose whatever they need to keep code quality and API consistent high. -- Doug Turner On Thursday, April 24, 2014 at 4:31 PM, Bobby Holley wrote: > On Thu, Apr 24, 2014 at 3:58 PM, Gavin Sharp <ga...@gavinsharp.com > (mailto:ga...@gavinsharp.com)> wrote: > > > Those asides are precisely the reason it's "abuse" :) > > > > We should update the list > > > What is the list good for, exactly? There doesn't seem to be any consistent > usage of it anymore. In the areas that I work on (JS, XPConnect, DOM, and > other internals), it's occasionally used to indicate that the reviewer is > being requested for a more high-level review. But whether the requestee is > on that list never seems all that relevant. > > Put another way - without a clear rule, requesting sr is basically a > judgement call these days. Given that, curating a strict list of potential > requestees doesn't buy us very much. > > bholley > _______________________________________________ > dev-platform mailing list > dev-platf...@lists.mozilla.org (mailto:dev-platf...@lists.mozilla.org) > https://lists.mozilla.org/listinfo/dev-platform > >
_______________________________________________ dev-b2g mailing list dev-b2g@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-b2g
