On 5/12/2014 9:51 AM, Michael Shal wrote:
From: "Joshua Cranmer 🐧" <[email protected]>
On 5/11/2014 9:14 AM, Ehsan Akhgari wrote:
Perhaps I missed this, but your post doesn't talk about why this
separation is useful. I don't understand why the existing command
lines in rules.mk are not useful...
The current setup hides a lot of the command line from
non-recursive-make systems. The most notable use case for this at the
moment are things like clang compilation databases or the Eclipse or VS
project backends, where we need several command-line flags to correctly
compile code. Hopefully that should be sufficient motivation for why
these ought to be visible at the moz.build level.
As to why I proposed the breakdown like this: I started with a pass that
would have remitted all the global flags to each backend.mk file by
directly porting config.mk logic to python, to which Mike Hommey
objected in part due to the redundancy of the emission (and also a
belief that this was configure's role, which I don't necessarily
disagree with).
Would your proposal still be necessary if we could do the following?
1) Finish the rest of the Makefile.in -> moz.build conversion, so the
per-directory configuration is in a single file (instead of part of it in
make-syntax and part in python)
Almost all of the relevant flags for the command line are converted.
There's a few pieces related to overriding OS_CXXFLAGS and the like, but
the conversion is sufficient to start thinking about this problem.
2) Settle on a way to handle bug 930703
This *is* the proposal to handle bug 930703. :-)
--
Joshua Cranmer
Thunderbird and DXR developer
Source code archæologist
_______________________________________________
dev-builds mailing list
[email protected]
https://lists.mozilla.org/listinfo/dev-builds
