----- Original Message ----- > From: "Joshua Cranmer 🐧" <[email protected]> > To: [email protected] > Sent: Monday, May 12, 2014 11:29:12 AM > Subject: Re: RFC: On making command lines knowable to moz.build > > On 5/12/2014 9:51 AM, Michael Shal wrote: > > 2) Settle on a way to handle bug 930703 > > This *is* the proposal to handle bug 930703. :-)
Oh, ok - I missed that somehow! :) Can you or glandium elaborate on the issues with the most recent patch there? I may have missed some IRC discussion on it... > 1. Start combining the global flags into a single GLOBAL_CFLAGS rule, > and make the logic for emitting this happen at configure-time, not in > config.mk. I kind of prefer doing this in moz.build somehow since python > is a far easier language to do logic in than Makefile or m4-augmented > shell-script, but as long as this knowledge is easily communicable to > moz.build (e.g., via CONFIG), that should satisfy most use cases. I tend to favor having the logic in python as well (as opposed to configure / Makefiles) since we've already started to move in that direction for moz.build. Personally I think configure should just output the list of variables based on the user configuration (.mozconfig) and system-derived attributes, and the logic should be handled outside of configure. Then we can change the logic without having to re-run configure. IOW, right now we have something like: 1) build configuration: configure 2) build logic: split between configure, python/mozbuild/*, config/config.mk and config/rules.mk 3) build frontend: split between Makefile.in and moz.build I think it would be more cleanly separated as: 1) build configuration: configure 2) build logic: python/mozbuild/* 3) build frontend: moz.build Just my 2c. -Mike _______________________________________________ dev-builds mailing list [email protected] https://lists.mozilla.org/listinfo/dev-builds
