> On 3 Feb 2016, at 09:26, Alexandre Lissy <[email protected]> wrote:
> 
> Le 03/02/2016 10:14, Chris Mills a écrit :
>> 
>>> On 2 Feb 2016, at 20:05, Alexandre Lissy <[email protected]> wrote:
>>> 
>>> Le 01/02/2016 13:48, Chris Mills a écrit :
>>>> Hi folks,
>>>> 
>>>> I’ve given the following articles an edit:
>>>> 
>>>> https://developer.mozilla.org/en-US/docs/Mozilla/Firefox_OS/Building_and_installing_Firefox_OS/B2G_installer_add-on
>>> 
>>> Thanks for the review! I have added much more informations, so it is
>>> likely you are going to need to have another look :)
>> 
>> not a problem — I’ve edited your updates. The only but I’m not sure about is 
>> this:
>> 
>> https://developer.mozilla.org/en-US/docs/Mozilla/Firefox_OS/Building_and_installing_Firefox_OS/B2G_installer_add-on#Adding_new_device_support
>> 
>> Check this carefully. For example, I was a bit confused by "If your device 
>> does have support…” . Surely if it already has support then you don’t need 
>> to add it? So I changed it to "If your device does not have support for 
>> this”. Is this correct? I think it could do with a bit more clarity.
> 
> No, that's incorrect. There are two components here: being able to
> produce a blobfree distribution, and making it exposed in the addon. The
> sentence "if your device does have support" is about the ability to be
> able to produce a blobfree distribution.
> 
> Said otherwise, |./build.sh blobfree| should work on your device's port.

Ah, thanks for the clarification — makes sense now. The doc looks fine too.
_______________________________________________
dev-fxos mailing list
[email protected]
https://lists.mozilla.org/listinfo/dev-fxos

Reply via email to