Hi, Recently I read Dave Townsend's thread about "Super-review, what shall we do with you?" and realized there wasn't any conclusion to that.
As a relative new dev, I think it is vital to have a clear distinction as to when a sr is required. I've only done a few patches that required sr (c-c stuff) and I don't recall any m-c patches I did required sr (or not that I know of). But I feel that as I gain more understanding of the code, I'll encounter the sr flag more frequently. So I feel it is important that a new dev understands clearly what the sr? flag is and under what conditions it is required. To veteran devs it might be very evident, but it isn't for a new dev, at least, not to me. My understanding is that a sr flag is needed when there's an API change or a UI change. What constitutes an API change or at least, to what extent would an API need to change in order to require a sr? For example, for the "EnumerateForwards/Backwards removal" bug (bug #819940), would it have qualified as an API change that required sr? The bug didn't explain the rationale for the removal so I'm assuming it was important or required. Thanks for any clarifications, Edmund _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
