Also, for those who are interested, I'm working on a script that will (hopefully) be a pre-commit hook for checking that IDL changes have corresponding IID changes (if needed):
https://github.com/jwir3/checkiid Feel free to use it if you want to test your patches for compliance, and also to test the script itself. There are still a number of issues, so it's pretty rough yet, but it's getting better. Patches are, of course, accepted. ;) ~Scott On Wed 29 May 2013 01:50:14 PM CDT, Benoit Girard wrote: > On Mon, May 27, 2013 at 10:54 PM, Anthony Jones <ajo...@mozilla.com> wrote: >> A pre-upload check would give the fastest feedback. > > I'll be checking in a script in the mozilla repo that can be ran offline > and produce the same results. > > On Tue, May 28, 2013 at 10:44 AM, Mike Hoye <mh...@mozilla.com> wrote: > >> On 2013-05-27 10:54 PM, Anthony Jones wrote: >> >>> A pre-upload check would give the fastest feedback. >>> >>> It would help me (and those who review my code) if there is an easy way >>> to check my patches from the command line before doing hg bzexport. Even >>> if it is only for white space. What we need is a way to specify which >>> file paths the standard formatting rules apply to. I just need to figure >>> out how to install clang-format. >>> >> >> The clang-format list tells me that there are near-term plans for a >> standalone "clang-tidy" utility built on clang-format that will do much of >> what we're looking for as far as basic code-cleanup goes. I'm asking around >> about what "near-term" means, and if the answer isn't good enough I'm going >> to try to add something to clang-format to give users some moz-style >> guidance as a temporary measure. >> >> > I'd be happy to replace what's I'll be rolling out in bug 875605 once > something better comes along. But c++ isn't new so I'm not holding my > breath :). > _______________________________________________ > dev-platform mailing list > dev-platform@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-platform _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
