On Fri, May 24, 2013 at 08:40:29AM -0700, Michael Hoye wrote: > ----- Original Message ----- > > > From: "Benjamin Smedberg" <benja...@smedbergs.us> To: "Scott > > Johnson" <sjohn...@mozilla.com> Cc: dev-platform@lists.mozilla.org, > > "Michael Hoye" <mh...@mozilla.com> > > > * Automated tools: mhoye has identified lack of automated review as > > one of our biggest blockers to getting more mentors involved and > > having successful mentoring for new volunteers. It turns out that > > nobody wants to mentor bugs when most of the interaction involves > > "please fix this whitespace/style/etc". cc'ing him so he can provide > > more details. > > Yeah, so, about that. > > Having spoken to a handful of developers, this is #2 on the List Of > Things People Dislike About Mentoring, having to go back-and-forth > with a contributor about style conventions and whitespace. In short, > everyone hates it, everyone understands that this should be completely > and utterly automated. A question I'm trying to clear up for myself > is: I understand that clang-format is somehow inadequate to our needs, > but I see that there's an explicit "clang-format -style=Mozilla" > option that claims to be doing the right Mozilla thing. So, I'm hoping > somebody can give me a clearer idea of how clang-format is broken.
clang-format unfortunately only deals with whitespaces. It does have neat formatting with them, but it's limited to that. Unfortunately, coding style is also about naming conventions (camel case, hungarian notation, etc.), braces positions and presence, etc. Triple-unfortunately, we have an almost infinite number of combinations of those. CELS is a tool that can help with these. https://bitbucket.org/PEConn/cels Mike _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
