Going back to the idl is probably the best. It isn't just attributes, though, its also structure definitions as well, like: http://dxr.mozilla.org/mozilla-central/source/dom/ipc/PContent.ipdl#l73
So if I'm on this line: http://dxr.mozilla.org/mozilla-central/source/dom/devicestorage/DeviceStorageRequestParent.cpp#l196 DeviceStorageFreeSpaceParams doesn't show as a known structure (i.e. no Jump to definition) Dave Hylands ----- Original Message ----- > From: "Ehsan Akhgari" <ehsan.akhg...@gmail.com> > To: "Erik Rose" <e...@mozilla.com>, "Dave Hylands" <dhyla...@mozilla.com> > Cc: dev-platform@lists.mozilla.org > Sent: Friday, October 25, 2013 8:10:42 AM > Subject: Re: Poll: What do you need in MXR/DXR? > > On 2013-10-25 10:45 AM, Erik Rose wrote: > >>> What features do you most use in MXR and DXR? > >> > >> One feature I'd like to see in DXR is the ability to click on a header > >> file shown in a #include and have it be opened. > >> > >> For example, if I search for ErrorResult, I see > >> > >> #include "mozilla/ErrorResult.h" > >> > >> I'd like to be able to click on the #include and have it be opened. > > > > You, my friend, are in luck. It so happens that I reimplemented that > > feature last week. It used to be based on some post-build heuristics and > > only worked some of the time. Now it sits in the clang compiler plugin and > > knows exactly what clang knows, so it works all the time. In fact, the > > only thing keeping it from looking like it works is that we stink at > > building markup (unbalanced tags! ick!) due to a error-prone and > > labyrinthian interval-overlap-resolution algorithm, which I'm rewriting as > > we speak. If all goes well, you should see the results in tomorrow's > > build, and you shouldn't have any more trouble with includes. > > > >> It would also be really nice to have the source and header files which are > >> generated from .idl and .ipdl files be included in the index. > > > > What I'm rewriting is part of the build process, and that's the process I'd > > have to refactor to make your request a reality. A question for you: would > > it be better, from your point of view, to index the generated files or to > > magically turn up the IDL line "attribute short foo" when you search for > > "function:GetFoo" or "function:SetFoo"? (I'm not sure both are feasible; I > > just want to get an early read.) > > The latter is better in my opinion! > > Cheers, > Ehsan > _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
