On 03/18/2014 06:10 PM, Karl Tomlinson wrote: > But for links in bugzilla, please link to a page associated with a > particular revision number, or the line numbers can get very out > of date. Unfortunately I'm not aware of multi-line highlighting > on hg.mozilla.org so this becomes something like > > http://hg.mozilla.org/mozilla-central/annotate/082761b7bc54/content/media/AbstractMediaDecoder.h#l7 > > I don't know the expected lifetime of > https://github.com/mozilla/gecko-dev/ so I wouldn't be comfortable > recommending > > https://github.com/mozilla/gecko-dev/blob/f2ceb1102370652f57952af3c3829ae19dc04d56/content/media/AbstractMediaDecoder.h#L7-L13
Thanks for the input! I think there's some great feedback in this thread that can be used to build this functionality. It's a 'killer feature' request that you can track here: https://bugzilla.mozilla.org/show_bug.cgi?id=962108 Some background, which that bug notes as well: as of how DXR works today, implementing a permalink (with highlighting) will only be able to provide a point in time HTML snapshot of a file. This limitation is due to how DXR periodically generates an index for a code base, and renders static HTML pages thereof. Each run is a separate index and set of HTML output, which is not stored due to the amount of disk space required for each run. Thus, a permalink would not be representative of the indexed version of a file in a particular repository at any past revision (unless the current page that is permalinked is the same code that is in TIP/HEAD). However, the Navigation panel, Search, or the contextual overlay links would all still function for permalinked pages. They would just point a user to the live index of a code base itself. Moreover, with the right design of this functionality now, when on demand rendering goes live, all existing permalinks ought to be able to remain, and point to a dynamically generated index of the intended past revision instead of the old HTML version. Cheers, Jamon _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
