On 4/1/14, 10:05 AM, Benoit Jacob wrote: > This macro is especially heavily used in SpiderMonkey. Maybe > SpiderMonkey developers could weigh in on how large are the benefits > brought by UNREACHABLE there?
I don't believe there are any benefits. Those uses of MOZ_ASSUME_UNREACHABLE are not intended as optimizations. When they were inserted, they used JS_NOT_REACHED, which called the assertion failure code and crashed hard, even in non-debug builds. Bug 723114 changed the semantics of the existing macro. Later, the name was changed. In hindsight, that was a big safety regression. By all means back it out. -j _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
