Minor spec suggestion: This looks like a great primitive, but having to create GC pressure to multiply values by the matrix seems like a real mistake. transformPoint should have an overload that accepts a Float64Array and mutates it in-place, or maybe a 'in, out' pair of arrays. Probably also accept offsets into each array so that you can use it to transform a series of points by the matrix (a fairly common graphics/geometry operation).
On Mon, Jun 2, 2014 at 8:32 PM, Robert O'Callahan <rob...@ocallahan.org> wrote: > On Tue, Jun 3, 2014 at 3:28 PM, Rik Cabanier <caban...@gmail.com> wrote: > >> Yes, isIdentity is used as an indication that nothing needs to be done or >> that the transform hasn't changed. >> Maybe we should rename it to isDefault, isInitial or isNoOp? >> > > I think isIdentity is the right name. > > Glancing through Gecko I see places where we're able to entirely skip > possibly-expensive transformation steps if we have an identity matrix, so I > guess isIdentity is useful to have since even if we make > multiplication-by-identity free, checking isIdentity might mean you can > completely avoid traversing some application data structure. > > Rob > -- > Jtehsauts tshaei dS,o n" Wohfy Mdaon yhoaus eanuttehrotraiitny eovni > le atrhtohu gthot sf oirng iyvoeu rs ihnesa.r"t sS?o Whhei csha iids teoa > stiheer :p atroa lsyazye,d 'mYaonu,r "sGients uapr,e tfaokreg iyvoeunr, > 'm aotr atnod sgaoy ,h o'mGee.t" uTph eann dt hwea lmka'n? gBoutt uIp > waanndt wyeonut thoo mken.o w > _______________________________________________ > dev-platform mailing list > dev-platform@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-platform _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
