On 2015-01-02 3:32 PM, Brian Smith wrote:
Ehsan Akhgari <ehsan.akhg...@gmail.com> wrote:
On 2015-01-02 2:03 PM, Brian Smith wrote:
In this case, the problem is that I wrote a patch to explicitly
delete ("= delete") some members of classes in mozilla::pkix.
mozilla::pkix cannot depend on MFBT for licensing and build
independence reasons (e.g. so it can be put into NSS). I don't
want to add the equivalent of MOZ_DELETE to mozilla::pkix just to
make MSVC2012 work.
= delete currently cannot be used in Mozilla code according to
<https://developer.mozilla.org/en-US/docs/Using_CXX_in_Mozilla_code>.
I realize that now. It is very unfortunate that the rules for using
C++ in Mozilla code are not simply "if it passes tryserver, it's
OK." I hope that Mozilla accelerates its deprecation for old
compilers (GCC less than 4.8, in particular, so that "enum class" can
be used safely) and improves the automation.
We are *very* interested in supporting fewer compiler versions as well.
There are usually some factors that limit how aggressive we can be
here (such as Linux distros using gcc versions older than what we'd
like, and the b2g toolchain dependencies that we cannot necessarily
control). Thanks for being patient while we get better at this. :-)
FWIW to the best of my knowledge, we have kept the last two MSVC
releases supported for quite a long time, but I don't know if there has
ever been a good reason for that (besides people having them installed
locally.) I would very much like us to change that tradition!
I am not sure why you don't want to add the equivalent of
MOZ_DELETE given how easy that is.
Our personal opinion about MSVC2012 aside, without a decision to
drop support for MSVC2012, we cannot say no to fixing the build
issues specific to that compiler, and such decision has not been
made so far.
First, I will back out the offending patch pending a resolution of
this discussion, in the interests of being a good team player while
this discussion unfolds. I've already asked a VS2012 user to review
the patch here:
https://bugzilla.mozilla.org/show_bug.cgi?id=1117003#c3
Thank you!
However, I think my time is better spent arguing for dropping
MSVC2012 support (and allowing "= delete") than writing another "=
delete" macro. So, let's try to resolve that it is OK to drop
MSVC2012 support in Firefox 37 now.
That's fair. :-) FWIW as I said elsewhere in the thread I think that
the default answer at the lack of evidence to the contrary should be for
us to drop MSVC2012, so perhaps you don't need to argue that strongly
after all!
Cheers,
Ehsan
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform
