No, it does not catch MOZ_RELEASE_ASSERT, because that doesn't call
NS_DebugBreak and that is what does the AbortMessage annotation[1].
NS_RUNTIMEABORT is the recommended way to reliably crash if you're in
XPCOM-y code.

Bug 1104682 is filed for this, though. I'd love for somebody to take this.

--BDS

[1]
http://mxr.mozilla.org/mozilla-central/source/xpcom/base/nsDebugImpl.cpp#392

On Wed, Apr 6, 2016 at 5:29 PM, Kyle Huey <m...@kylehuey.com> wrote:

> Does this catch MOZ_RELEASE_ASSERT and similar?  It would be nice to
> distinguish those somehow in crash-stats.
>
> - Kyle
>
> On Wed, Apr 6, 2016 at 2:18 PM, Benjamin Smedberg <bsmedb...@mozilla.com>
> wrote:
>
>> A change just landed which will change the way crash signatures are
>> computed for intentional aborts. Previously the crash signature would be
>> "NS_DebugAbort | <caller>". Now the signature will be "Abort | <abort
>> message up to 80 chars> | <caller>".
>>
>> This should make it much easier to distinguish various classes of abort.
>>
>> Thanks to Adrian Gaudebert for taking this in bug 803779!
>>
>> --BDS
>>
>> --
>> Benjamin Smedberg
>> Engineering Manager, Firefox
>> _______________________________________________
>> dev-platform mailing list
>> dev-platform@lists.mozilla.org
>> https://lists.mozilla.org/listinfo/dev-platform
>>
>
>


-- 
Benjamin Smedberg
Engineering Manager, Firefox
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Reply via email to