Thanks Benjamin! Here's a search that shows what those new signatures look like on stage: https://crash-stats.allizom.org/search/?product=Firefox&signature=%5EAbort&_facets=abort_message&_columns=date&_columns=signature&_columns=abort_message
Please let me know if that seems good or not before we push this change to prod. :) Cheers, Adrian On Thu, Apr 7, 2016 at 3:27 AM, Bobby Holley <bobbyhol...@gmail.com> wrote: > On Wed, Apr 6, 2016 at 2:34 PM, Benjamin Smedberg <bsmedb...@mozilla.com> > wrote: > >> No, it does not catch MOZ_RELEASE_ASSERT, because that doesn't call >> NS_DebugBreak and that is what does the AbortMessage annotation[1]. >> NS_RUNTIMEABORT is the recommended way to reliably crash if you're in >> XPCOM-y code. >> > > That's unfortunate, because according to MXR (and anecdotally) almost > everyone uses MOZ_CRASH. > > _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
