On 04/08/2016 02:55 PM, Daniel Holbert wrote: > On 04/08/2016 10:38 AM, Jip de Beer wrote: >> I didn't manage to dump the Frame Tree using lldb... I followed these guides: > [...] >> I tried with Firefox, FirefoxDeveloperEdition and the nightly build (ran >> lldb from Terminal as well as Xcode). >> I was able to attach lldb to the browser, but not output a Frame Tree dump. >> The code for the nightly build was unmodified. When I tried to define >> DEBUG_FRAME_DUMP in layout/generic/nsFrameList.h (by uncommenting a block of >> code) the build failed. > > Please report that build failure as a bug with more details! We likely > are accidentally intermixing assumptions about #ifdef DEBUG and #ifdef > DEBUG_FRAME_DUMP or something
(BTW, I tested this locally, and I didn't hit any build failures. So I may be doing something different from you, and I'm not as sure there's a real build-error bug hiding here after all -- it's possible you were tripping over an unrelated build error of some sort. But, if you can still reproduce this build error, please do report it (including details on the change that you made and the build error output), here: https://bugzilla.mozilla.org/enter_bug.cgi?product=Core&component=Layout ) Anyway, as noted in my previous email, even if this nsFrameList.h tweak works, the better-supported interactive way to get frametree dumps is to generate a build with ac_add_options --enable-debug in your mozconfig, and to use the layout debugger's "Dump" menu. We conceivably *could* add instrumentation to normal builds, but this would require shipping extra Gecko code that a vanishingly small subset of users would actually benefit from, so it doesn't seem worth it. Depending on the use case, it might be better to just write & expose a more generic element-bounding-box-dumping tool in devtools. ~Daniel _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
