On 02/06/2017 08:19 AM, Mike Hoye wrote:
On 2017-02-03 2:01 PM, Steve Fink wrote:
Typo/whitespace - No bug is fine, but if it is associated with a
recent landing of some bug, then you should use that bug number
anyway. Makes uplifts cleaner.
Whitespace errors seem like a wierd thing for an engineer to be
working on?. Code cleanup bugs are how a lot of people get started,
and could also have automatic formatting. Employees pushing whitespace
around seems like a distant third-best.
While I also don't want people to suffer from unnecessary process
overhead, I also want small-change bugs to be discoverable by people
trying to start contributing. I'm not sure where that line is, but
changes without bugs means nobody else could have helped make those
changes.
The scenario I'm thinking of is that I land something, and notice (or
somebody points out) that I added whitespace at the end of a line
somewhere. Landing an immediate fix seems like the lowest overhead way
of dealing with it, other than ignoring it entirely. But ignoring it
would cause a small amount of friction for other people, so I'd rather
clean up after myself if I notice.
A related situation is when starting to work on something, you find it
has trailing whitespace scattered around. I like to have a separate
whitespace fixup commit, to make the following changes more clear.
That's the case where I wouldn't look up the bug where the whitespace
was landed. (First, because it's a bit of nuisance to look up, and
second, associating it with some old bug is going to cause more harm
than good, especially if things have modified stuff in between.) I'm not
really sure whether it's better to label such a changeset with "No bug"
or with the new bug from the following changeset. I guess the latter
would be better for uplifts. (Though I'll often squash things that I may
want to uplift and attach that as an upliftable patch so I don't have to
request approval on multiple patches and it's just easier to deal with
one patch at a time.)
Otherwise, yeah, I'm not going to go around looking for whitespace
problems. I only deal with whitespace if it gets in my way, or if I
recently introduced it.
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform
