On Sat, May 20, 2017 at 6:36 AM, Martin Thomson <m...@mozilla.com> wrote: > Hmm, these are all -Wsign-compare issues bar one, which is fixed > upstream. We have an open bug tracking the warnings > (https://bugzilla.mozilla.org/show_bug.cgi?id=1307958 and specifically > https://bugzilla.mozilla.org/show_bug.cgi?id=1212199 for NSS). > > NSS is built with -Werror separately, but disables errors on > -Wsign-compare. Disabling those warnings for a Firefox build of NSS > wouldn't be so bad now that we share gyp config. Based on a recent > build, that's 139 messages (add 36 if you want to add nspr).
Where does NSS do this? Cloning the NSS tree and grepping for sign-compare turns up no disabling of -Wsign-compare, except perhaps in XCode for gtest itself. Thanks, -Nathan _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
