On Sat, 20 May 2017 14:59:11 -0400, Eric Rescorla wrote: > On Sat, May 20, 2017 at 1:16 PM, Kris Maglione <kmagli...@mozilla.com> > wrote: > >> On Sat, May 20, 2017 at 08:36:13PM +1000, Martin Thomson wrote: >> >>> Hmm, these are all -Wsign-compare issues bar one, which is fixed >>> upstream. We have an open bug tracking the warnings >>> (https://bugzilla.mozilla.org/show_bug.cgi?id=1307958 and specifically >>> https://bugzilla.mozilla.org/show_bug.cgi?id=1212199 for NSS). >>> >>> NSS is built with -Werror separately, but disables errors on >>> -Wsign-compare. Disabling those warnings for a Firefox build of NSS >>> wouldn't be so bad now that we share gyp config. Based on a recent >>> build, that's 139 messages (add 36 if you want to add nspr). >>> >> >> Is there a particularly good reason that NSS needs to disable >> -Wsign-compare? That seems like a footgun waiting to happen, especially in >> crypto code. > > > Like many other pieces of old code, there are a lot of things that trigger > compiler warnings which we have been progressively removing, but we > haven't removed these yet. Ideally we would have some tooling that > would distinguish new warnings from old warnings, but absent that, > until we fix all the existing warnings it's either disable -Werror or > disable this particular warning. It's not something we're particularly > happy about.
-Wno-error=sign-compare is also an option, but a wall of sign-compare warnings may not be helpful in general. _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
