On Wed, Aug 30, 2017 at 4:41 PM, Jeff Gilbert <jgilb...@mozilla.com> wrote:
> IMO: Never else-for. (or else-while)
>
> Else-if is a reasonable continuation of concept: "Well it wasn't that,
> what if it's this instead?"
> Else-for is just shorthand for "well it wasn't that, so let's loop
> over something".
>
> Else-if is generally used for chaining, often effectively as an
> advanced switch/match statement.
>
> I've never actually seen else-for, but I imagine it would be used for:
> if (!foo) {
> } else for (i = 0; i < foo->bar; i++) {
> }
>
> I don't think this pattern has enough value to be acceptable as
> shorthand. BUT, I didn't know it was a thing until now, so I'm
> naturally biased against it.
>
I'm with Jeff here. Not even once.
if (!foo) {
} else {
for(...) {
}
}
As it happens, the style guide agrees with us, so I'm happy to quote it ;)
"else should only ever be followed by { or if; i.e., other control keywords
are not allowed and should be placed inside braces."
-Ekr
-Ekr
> On Wed, Aug 30, 2017 at 2:58 PM, <gsquel...@mozilla.com> wrote:
> > Let's keep the flames alive!
> >
> > Should we always put braces after an `else`, with the only exception
> being another `if`?
> > Or should we also have exceptions for the other control structures
> (while, do, for, switch)?
> >
> > A.
> > if (...) {
> > ...
> > } else {
> > for (...) {
> > ...
> > }
> > }
> >
> > B.
> > if (...) {
> > ...
> > } else for (...) {
> > ...
> > }
> >
> > I can see arguments for&against both, so I'm not too sure which one
> should win. :-)
> > WDYT?
> > _______________________________________________
> > dev-platform mailing list
> > dev-platform@lists.mozilla.org
> > https://lists.mozilla.org/listinfo/dev-platform
> _______________________________________________
> dev-platform mailing list
> dev-platform@lists.mozilla.org
> https://lists.mozilla.org/listinfo/dev-platform
>
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform
