It's not just eslint either. We warn in static analysis now when using `!std::vector::size()` instead of `empty()`. Such over-prescriptive linting is unnecessary and unproductive.
On Sun, Dec 24, 2017 at 2:07 PM, Masatoshi Kimura <vyv03...@nifty.ne.jp> wrote: > > On 2017/12/25 6:31, Jonathan Kingston wrote: >> It has worked for me for quite some time just running ./mach lint >> filename.js after bootstrap. > > I got the following error when I tried it just now: > > --------------------------------------------------------------- > $ mach lint browser/base/content/aboutDialog.js > eslint-plugin-html v2.0.3 should be v4.0.0. > ESLint is an old version, clobbering node_modules directory > Clobbering node_modules... > Installing eslint for mach using > "d:\mozilla-build\node-v8.1.4-win-x64\npm.cmd install --loglevel=error"... > npm ERR! code ENOLOCAL > npm ERR! Could not install from > "tools\lint\eslint\eslint-plugin-mozilla" as it does not contain a > package.json file. > > npm ERR! A complete log of this run can be found in: > npm ERR! > C:\Users\****\AppData\Roaming\npm-cache\_logs\2017-12-24T21_55_36_055Z-debug.log > > Error installing eslint, aborting. > Could not find eslint! We looked at the --binary option, at the ESLINT > environment variable, and then at your local node_modules path. Please > Install > eslint and needed plugins with: > > mach eslint --setup > > and try again. > A failure occured in the eslint linter. > ? 1 problem (0 errors, 0 warnings, 1 failure) > --------------------------------------------------------------- > > It is a really frustrating task to run eslint (and keep a working > environment) on Windows. > _______________________________________________ > dev-platform mailing list > dev-platform@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-platform _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
