On 03/01/2018 14:57, Mark Banner wrote:
On 24/12/2017 22:07, Masatoshi Kimura wrote:
---------------------------------------------------------------
$ mach lint browser/base/content/aboutDialog.js
eslint-plugin-html v2.0.3 should be v4.0.0.
ESLint is an old version, clobbering node_modules directory
Clobbering node_modules...
Installing eslint for mach using
"d:\mozilla-build\node-v8.1.4-win-x64\npm.cmd install
--loglevel=error"...
npm ERR! code ENOLOCAL
npm ERR! Could not install from
"tools\lint\eslint\eslint-plugin-mozilla" as it does not contain a
package.json file.
In this case, I think it incorrectly removed the
tools\lint\eslint\eslint-plugin-mozilla directory, if you check your
source tree diffs, you should see if that was the case or not (though
since this was a while ago, you may have already found that by now).
I've a feeling I know why, unfortunately my windows environment isn't
very good at the moment, so I'll need to get that updated to investigate.
Just to follow up on this, this was a one-off issue due to a bad clobber
when we attempted to update from v3 to v4 of ESLint. I've tracked down
the issue <https://bugzilla.mozilla.org/show_bug.cgi?id=1428305>, and
I'm near to a patch.
The workaround is running a revert on tools/lint/eslint/ and then
running eslint again - though I suspect as we did the upgrade a while
ago, most people will have already fixed this themselves.
Mark.
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform
