On Thu, Aug 30, 2018 at 6:04 PM, Michael Shal <ms...@mozilla.com> wrote:
>
>
> In this case, the 99:44 rebuild times look to be an artifact of how the
> outputs of GenerateServoStyleConsts.py are consumed by a large chunk of the
> Rust and C++ code. Attached is a graphviz .dot file for reference (with
> graphviz, 'dot -Tpng servo-style-consts.dot > servo-style-consts.png' and
> view the image).
>
I'm told the attachment was eaten. Here it is inline:
digraph G {
node_148923 [label="lib.rs\n" shape="oval" color="#000000"
fontcolor="#000000" style=solid];
node_1746856 -> node_148923 [dir=back,style="solid",arrowtail="empty"];
node_272075 [label="<installed-files>\n" shape="hexagon"
color="#000000" fontcolor="#000000" style=solid];
node_1632132 -> node_272075 [dir=back,style="solid",arrowtail="empty"];
node_285514 -> node_272075 [dir=back,style="solid",arrowtail="empty"];
node_272674 -> node_272075 [dir=back,style="solid",arrowtail="empty"];
node_272099 [label="Unified_cpp_storage0.o\n529 files" shape="oval"
color="#000000" fontcolor="#000000" style=solid];
node_1632132 -> node_272099 [dir=back,style="solid",arrowtail="empty"];
node_286141 -> node_272099 [dir=back,style="solid",arrowtail="empty"];
node_272100 [label="CXX Unified_cpp_storage0.cpp\n529 commands"
shape="rectangle" color="#000000" fontcolor="#000000" style=solid];
node_1632132 -> node_272100 [dir=back,style="solid",arrowtail="empty"];
node_272099 -> node_272100 [dir=back,style="solid",arrowtail="empty"];
node_288318 [label="TestDownscalingFilterNoSkia.o\n22 files"
shape="oval" color="#000000" fontcolor="#000000" style=solid];
node_1632132 -> node_288318 [dir=back,style="solid",arrowtail="empty"];
node_288319 [label="CXX
/home/mshal/mozilla-central-git/image/test/gtest/TestDownscalingFilterNoSkia.cpp\n22
commands" shape="rectangle" color="#000000" fontcolor="#000000"
style=solid];
node_1632132 -> node_288319 [dir=back,style="solid",arrowtail="empty"];
node_288318 -> node_288319 [dir=back,style="solid",arrowtail="empty"];
node_1826863 [label="atom_macro.rs\n52 files" shape="oval"
color="#000000" fontcolor="#000000" style=solid];
node_1826929 -> node_1826863 [dir=back,style="solid",arrowtail="empty"];
node_1826917 [label="RUN style v0.0.1 Target -> atom_macro.rs
bindings.rs ...\n" shape="rectangle" color="#000000" fontcolor="#000000"
style=solid];
node_1826863 -> node_1826917 [dir=back,style="solid",arrowtail="empty"];
node_1746854 [label="ServoStyleConsts.h\n" shape="oval" color="#000000"
fontcolor="#000000" style=solid];
node_1826917 -> node_1746854 [dir=back,style="solid",arrowtail="empty"];
node_288319 -> node_1746854 [dir=back,style="solid",arrowtail="empty"];
node_272100 -> node_1746854 [dir=back,style="solid",arrowtail="empty"];
node_272075 -> node_1746854 [dir=back,style="solid",arrowtail="empty"];
node_1746855 [label="ServoStyleConsts.h.pp\n" shape="oval"
color="#000000" fontcolor="#000000" style=solid];
node_272075 -> node_1746855 [dir=back,style="solid",arrowtail="empty"];
node_1746856 [label="python
/home/mshal/mozilla-central-git/layout/style/GenerateServoStyleConsts.py:generate
-> [ServoStyleConsts.h, ServoStyleConsts.h.pp]\n" shape="rectangle"
color="#000000" fontcolor="#000000" style=solid];
node_1746855 -> node_1746856 [dir=back,style="solid",arrowtail="empty"];
node_1746854 -> node_1746856 [dir=back,style="solid",arrowtail="empty"];
node_272075 -> node_1746856 [dir=back,style="solid",arrowtail="empty"];
node_1826930 [label="libgeckoservo-390312fceaa9ecec.a\n" shape="oval"
color="#000000" fontcolor="#000000" style=solid];
node_1826931 [label="libgeckoservo-390312fceaa9ecec.rlib\n"
shape="oval" color="#000000" fontcolor="#000000" style=solid];
node_1826970 -> node_1826931 [dir=back,style="solid",arrowtail="empty"];
node_1826964 -> node_1826931 [dir=back,style="solid",arrowtail="empty"];
node_1826932 [label="RUSTC geckoservo v0.0.1 Target ->
libgeckoservo-390312fceaa9ecec.a libgeckoservo-390312fceaa9ecec.rlib\n"
shape="rectangle" color="#000000" fontcolor="#000000" style=solid];
node_1826931 -> node_1826932 [dir=back,style="solid",arrowtail="empty"];
node_1826930 -> node_1826932 [dir=back,style="solid",arrowtail="empty"];
node_1826963 [label="libgkrust_shared-241fc0da610eca62.rlib\n"
shape="oval" color="#000000" fontcolor="#000000" style=solid];
node_1826970 -> node_1826963 [dir=back,style="solid",arrowtail="empty"];
node_1826964 [label="RUSTC gkrust-shared v0.1.0 Target ->
libgkrust_shared-241fc0da610eca62.rlib\n" shape="rectangle" color="#000000"
fontcolor="#000000" style=solid];
node_1826963 -> node_1826964 [dir=back,style="solid",arrowtail="empty"];
node_272674 [label="<rust-libs>\n" shape="hexagon" color="#000000"
fontcolor="#000000" style=solid];
node_1632132 -> node_272674 [dir=back,style="solid",arrowtail="empty"];
node_285514 -> node_272674 [dir=back,style="solid",arrowtail="empty"];
node_285514 [label="<shlibs>\n" shape="hexagon" color="#000000"
fontcolor="#000000" style=solid];
node_1632132 -> node_285514 [dir=back,style="solid",arrowtail="empty"];
node_286144 [label="dependentlibs.list\n3 files" shape="oval"
color="#000000" fontcolor="#000000" style=solid];
node_1632132 -> node_286144 [dir=back,style="solid",arrowtail="empty"];
node_286147 [label="python
/home/mshal/mozilla-central-git/toolkit/library/dependentlibs.py:gen_list
-> [dependentlibs.list, dependentlibs.list.gtest, dependentlibs.list.pp]\n"
shape="rectangle" color="#000000" fontcolor="#000000" style=solid];
node_1632132 -> node_286147 [dir=back,style="solid",arrowtail="empty"];
node_286144 -> node_286147 [dir=back,style="solid",arrowtail="empty"];
node_288298 [label="libtestcrasher.so\n" shape="oval" color="#000000"
fontcolor="#000000" style=solid];
node_285514 -> node_288298 [dir=back,style="solid",arrowtail="empty"];
node_288299 [label="LINK libtestcrasher.so\n3 commands"
shape="rectangle" color="#000000" fontcolor="#000000" style=solid];
node_1632132 -> node_288299 [dir=back,style="solid",arrowtail="empty"];
node_318585 -> node_288299 [dir=back,style="solid",arrowtail="empty"];
node_288298 -> node_288299 [dir=back,style="solid",arrowtail="empty"];
node_285514 -> node_288299 [dir=back,style="solid",arrowtail="empty"];
node_318585 [label="xpcshell\n2 files" shape="oval" color="#000000"
fontcolor="#000000" style=solid];
node_1632132 -> node_318585 [dir=back,style="solid",arrowtail="empty"];
node_1632132 [label="<default>\n" shape="hexagon" color="#000000"
fontcolor="#000000" style=solid];
node_286140 [label="libxul.so\n" shape="oval" color="#000000"
fontcolor="#000000" style=solid];
node_288299 -> node_286140 [dir=back,style="solid",arrowtail="empty"];
node_286147 -> node_286140 [dir=back,style="solid",arrowtail="empty"];
node_285514 -> node_286140 [dir=back,style="solid",arrowtail="empty"];
node_286141 [label="LINK libxul.so\n" shape="rectangle" color="#000000"
fontcolor="#000000" style=solid];
node_286140 -> node_286141 [dir=back,style="solid",arrowtail="empty"];
node_285514 -> node_286141 [dir=back,style="solid",arrowtail="empty"];
node_1826969 [label="libgkrust-27f2091867d7f9c1.a\n" shape="oval"
color="#000000" fontcolor="#000000" style=solid];
node_286141 -> node_1826969 [dir=back,style="solid",arrowtail="empty"];
node_272674 -> node_1826969 [dir=back,style="solid",arrowtail="empty"];
node_1826970 [label="RUSTC gkrust v0.1.0 Target ->
libgkrust-27f2091867d7f9c1.a\n" shape="rectangle" color="#000000"
fontcolor="#000000" style=solid];
node_1826969 -> node_1826970 [dir=back,style="solid",arrowtail="empty"];
node_272674 -> node_1826970 [dir=back,style="solid",arrowtail="empty"];
node_1826928 [label="libstyle-98e047e8a9db94de.rlib\n" shape="oval"
color="#000000" fontcolor="#000000" style=solid];
node_1826970 -> node_1826928 [dir=back,style="solid",arrowtail="empty"];
node_1826964 -> node_1826928 [dir=back,style="solid",arrowtail="empty"];
node_1826932 -> node_1826928 [dir=back,style="solid",arrowtail="empty"];
node_1826929 [label="RUSTC style v0.0.1 Target ->
libstyle-98e047e8a9db94de.rlib\n" shape="rectangle" color="#000000"
fontcolor="#000000" style=solid];
node_1826928 -> node_1826929 [dir=back,style="solid",arrowtail="empty"];
node_3159 [label="mod.rs\n" shape="oval" color="#000000"
fontcolor="#000000" style=solid];
node_1826929 -> node_3159 [dir=back,style="solid",arrowtail="empty"];
node_1746856 -> node_3159 [dir=back,style="solid",arrowtail="empty"];
}
-Mike
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform
