On Tue, Apr 9, 2019, at 1:39 PM, Brian Grinstead wrote: > I'd like to rewrite markup in the tree to avoid using the [type] > attribute on <script> tags when it's unnecessary.
Sounds good to me. We could similarly remove type="text/css" from <style> elements. > 2) See if there are any general best-practices for getting this type of > change reviewed / landed. For example, should we prefer separate > commits / reviews per directory, or does a single tree-wide commit make > sense? I would go with a single patch, getting review at least from someone who would be aware of existing tests/dependencies on specific type="" attributes. Although bz, who is commenting in the bug, was the person I was thinking of for that. :-) > I've prepared a script that rewrites this across the tree. The script > and the generated patch can be seen at > https://bugzilla.mozilla.org/show_bug.cgi?id=1542877. The following > directories are excluded: > > - third_party > - testing/web-platform: I've excluded this because (a) I expected there > would be tests that are specifically checking behavior for scripts with > different [type] attributes and (b) I wasn't sure if we'd want to > upstream this change. It could be included if that’s wrong. You should exclude layout/reftests/w3c-received/ too. _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
