On Thu, Apr 25, 2019 at 9:38 AM Joel Maher <jma...@mozilla.com> wrote:
> > > On Thu, Apr 25, 2019 at 12:12 PM Bobby Holley <bobbyhol...@gmail.com> > wrote: > >> On Thu, Apr 25, 2019 at 3:36 AM Joel Maher <jma...@mozilla.com> wrote: >> >>> >>> >>> On Wed, Apr 24, 2019 at 1:39 PM Bobby Holley <bobbyhol...@gmail.com> >>> wrote: >>> >>>> > >>>>> > Thanks Mike! >>>>> > >>>>> > So Fennec is the last remaining non-e10s configuration we ship to >>>>> users. >>>>> > Given that Fennec test coverage is somewhat incomplete, we probably >>>>> want to >>>>> > keep running desktop 1proc tests until Fennec EOL. >>>>> >>>> >>> Fennec runs the full set of tests, there is no need to run non-e10s >>> tests on desktop to support Fennec. >>> >> >> I had the impression that we had a fair number of tests disabled under >> Fennec, but maybe not. In any case - insofar as non-e10s is a supported >> platform, it's useful to be able to hit those failures directly on Desktop >> tests rather than armv7 emulators - so there's still value in keeping 1proc >> enabled until Fennec EOL. >> >> > While tests are disabled under Fennec most have been reenabled if > possible- many tests are not relevant on Fennec. Desktop is much faster > than those android emulators. When we switch to Firefox 69 (May 13th) the > plan is to leave android 4.3 emulators around as tier-2 > (mozilla-central/try only) until we get all the tests ported over to the > new android 7.0 x86_64 emulators which are just as fast as desktop, run > geckoview, and are multi process. We are about halfway done with getting > tests running on there. For test suites that are running successfully on > the new emulators, we will turn them off on android 4.3, the plan is > probably early Q3 to be done. Fennec will ship off the 68 branch as that > will live on ESR for a while. > That all sounds sensible to me. As long as we're certain that we won't ship Fennec past ESR68, 1proc will cease to be a user-accessible configuration once Nightly moves to 69 in 2.5 weeks. Once that happens, I propose the following steps, in order: (1) Remove support for the e10s pref, per Gijs' suggestion above. (2) Define and launch a small "1proc-smoketest" job, based on mochitest-plain, with a handful of tests across various components to verify that things mostly work. (3) Turn off the existing 1proc jobs. Does this seem like a reasonable path forward? _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
