On Mon, Aug 5, 2019 at 4:14 PM Gabriele Svelto <gsve...@mozilla.com> wrote: > On 05/08/19 12:04, Henri Sivonen wrote: > > I has come to my attention that that putting non-header-only code > > under mfbt/ is something we're trying to get away from: > > https://bugzilla.mozilla.org/show_bug.cgi?id=1554062 > > > > Do we have an appropriate place for headers that declare entry points > > for non-header-only functionality (in my case, backed by Rust code) > > and that depend on types declared in headers that live under mfbt/ and > > that need to be available both to SpiderMonkey and the rest of Gecko? > > IIRC we have some stuff like that under mozglue/misc. The TimeStamp > class for example is used in both Gecko and SpiderMonky, has > platform-dependent C++ implementations (also linking to external > libraries) and uses MFBT headers.
Is mozglue only for Gecko and SpiderMonkey and not anything else? (I.e. not crash reporter or anything else that doesn't link the Rust crates that SpiderMonkey links?) In general, it seems problematic to organize headers based on whether they have associated .cpp or crate code. I'd expect developers to look for stuff under mfbt/ instead of some place else, since developers using the header shouldn't have to know if the implementation is header-only or not. :-( -- Henri Sivonen hsivo...@mozilla.com _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
